[0/4] KVM: x86: Kill off pdptrs_changed()

Message

Sean Christopherson April 23, 2021, 12:06 a.m. UTC

Remove pdptrs_changed(), which is mostly dead anyways, and the few bits
that are still thrashing are useless.

This conflicts with Maxim's work to migrate PDPTRs out-of-band, but I
think it will conflict in a good way as the "skip load_pdptrs()"
logic for the out-of-band case won't have to juggle this legacy crud.

Sean Christopherson (4):
  KVM: nVMX: Drop obsolete (and pointless) pdptrs_changed() check
  KVM: nSVM: Drop pointless pdptrs_changed() check on nested transition
  KVM: x86: Always load PDPTRs on CR3 load for SVM w/o NPT and a PAE
    guest
  KVM: x86: Unexport kvm_read_guest_page_mmu()

 arch/x86/include/asm/kvm_host.h |  4 ----
 arch/x86/kvm/svm/nested.c       |  6 ++---
 arch/x86/kvm/vmx/nested.c       |  8 +++----
 arch/x86/kvm/x86.c              | 41 ++++-----------------------------
 4 files changed, 10 insertions(+), 49 deletions(-)

Comments

Paolo Bonzini April 23, 2021, 7:04 a.m. UTC | #1

On 23/04/21 02:06, Sean Christopherson wrote:
> Remove pdptrs_changed(), which is mostly dead anyways, and the few bits
> that are still thrashing are useless.
> 
> This conflicts with Maxim's work to migrate PDPTRs out-of-band, but I
> think it will conflict in a good way as the "skip load_pdptrs()"
> logic for the out-of-band case won't have to juggle this legacy crud.

Maxim, can you integrate these patches in your series yourself?

Thanks,

Paolo

> Sean Christopherson (4):
>    KVM: nVMX: Drop obsolete (and pointless) pdptrs_changed() check
>    KVM: nSVM: Drop pointless pdptrs_changed() check on nested transition
>    KVM: x86: Always load PDPTRs on CR3 load for SVM w/o NPT and a PAE
>      guest
>    KVM: x86: Unexport kvm_read_guest_page_mmu()
> 
>   arch/x86/include/asm/kvm_host.h |  4 ----
>   arch/x86/kvm/svm/nested.c       |  6 ++---
>   arch/x86/kvm/vmx/nested.c       |  8 +++----
>   arch/x86/kvm/x86.c              | 41 ++++-----------------------------
>   4 files changed, 10 insertions(+), 49 deletions(-)
>