[0/2] Support for AF_UNIX -netdev socket and a small fix

Message

Stefano Brivio April 23, 2021, 3:30 p.m. UTC

Patch 1/2 introduces support for AF_UNIX stream-oriented socket to
be passed as -netdev, and patch 2/2 fixes a minor issue I found while
trying to connect to an invalid path.

Stefano Brivio (2):
  net: Allow also UNIX domain sockets to be used as -netdev socket
  net: Don't ignore EINVAL on netdev socket connection

 net/socket.c    | 109 +++++++++++++++++++++++++++++++++++++++---------
 qemu-options.hx |  12 +++---
 2 files changed, 95 insertions(+), 26 deletions(-)

Comments

[e-mail] April 23, 2021, 3:39 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH 0/2] Support for AF_UNIX -netdev socket and a small fix

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
8eacf39 net: Don't ignore EINVAL on netdev socket connection
17c0b6e net: Allow also UNIX domain sockets to be used as -netdev socket

=== OUTPUT BEGIN ===
1/2 Checking commit 17c0b6ec8d6b (net: Allow also UNIX domain sockets to be used as -netdev socket)
ERROR: braces {} are necessary for all arms of this statement
#38: FILE: net/socket.c:523:
+        if (parse_host_port(saddr_in, host_str, errp) < 0)
[...]

ERROR: braces {} are necessary for all arms of this statement
#74: FILE: net/socket.c:557:
+    if (pf == PF_INET)
[...]

ERROR: braces {} are necessary for all arms of this statement
#109: FILE: net/socket.c:606:
+        if (parse_host_port(saddr_in, host_str, errp) < 0)
[...]

total: 3 errors, 0 warnings, 163 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 8eacf3917406 (net: Don't ignore EINVAL on netdev socket connection)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]