| Message ID | 20210420024222.101615-1-ilya.lipnitskiy@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: mediatek/ralink: remove unused bindings | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, Apr 19, 2021 at 07:42:22PM -0700, Ilya Lipnitskiy wrote: > Revert commit 663148e48a66 ("Documentation: DT: net: add docs for > ralink/mediatek SoC ethernet binding") > > No in-tree drivers use the compatible strings present in these bindings, > and some have been superseded by DSA-capable mtk_eth_soc driver, so > remove these obsolete bindings. Looks like maybe OpenWRT folks are using these. If so, you can't revert them. > > Cc: John Crispin <john@phrozen.org> > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> > --- > .../bindings/net/mediatek,mt7620-gsw.txt | 24 -------- > .../bindings/net/ralink,rt2880-net.txt | 59 ------------------- > .../bindings/net/ralink,rt3050-esw.txt | 30 ---------- > 3 files changed, 113 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > > diff --git a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt b/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > deleted file mode 100644 > index 358fed2fab43..000000000000 > --- a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > +++ /dev/null > @@ -1,24 +0,0 @@ > -Mediatek Gigabit Switch > -======================= > - > -The mediatek gigabit switch can be found on Mediatek SoCs (mt7620, mt7621). > - > -Required properties: > -- compatible: Should be "mediatek,mt7620-gsw" or "mediatek,mt7621-gsw" > -- reg: Address and length of the register set for the device > -- interrupts: Should contain the gigabit switches interrupt > -- resets: Should contain the gigabit switches resets > -- reset-names: Should contain the reset names "gsw" > - > -Example: > - > -gsw@10110000 { > - compatible = "ralink,mt7620-gsw"; > - reg = <0x10110000 8000>; > - > - resets = <&rstctrl 23>; > - reset-names = "gsw"; > - > - interrupt-parent = <&intc>; > - interrupts = <17>; > -}; > diff --git a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt b/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > deleted file mode 100644 > index 9fe1a0a22e44..000000000000 > --- a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > +++ /dev/null > @@ -1,59 +0,0 @@ > -Ralink Frame Engine Ethernet controller > -======================================= > - > -The Ralink frame engine ethernet controller can be found on Ralink and > -Mediatek SoCs (RT288x, RT3x5x, RT366x, RT388x, rt5350, mt7620, mt7621, mt76x8). > - > -Depending on the SoC, there is a number of ports connected to the CPU port > -directly and/or via a (gigabit-)switch. > - > -* Ethernet controller node > - > -Required properties: > -- compatible: Should be one of "ralink,rt2880-eth", "ralink,rt3050-eth", > - "ralink,rt3050-eth", "ralink,rt3883-eth", "ralink,rt5350-eth", > - "mediatek,mt7620-eth", "mediatek,mt7621-eth" > -- reg: Address and length of the register set for the device > -- interrupts: Should contain the frame engines interrupt > -- resets: Should contain the frame engines resets > -- reset-names: Should contain the reset names "fe". If a switch is present > - "esw" is also required. > - > - > -* Ethernet port node > - > -Required properties: > -- compatible: Should be "ralink,eth-port" > -- reg: The number of the physical port > -- phy-handle: reference to the node describing the phy > - > -Example: > - > -mdio-bus { > - ... > - phy0: ethernet-phy@0 { > - phy-mode = "mii"; > - reg = <0>; > - }; > -}; > - > -ethernet@400000 { > - compatible = "ralink,rt2880-eth"; > - reg = <0x00400000 10000>; > - > - #address-cells = <1>; > - #size-cells = <0>; > - > - resets = <&rstctrl 18>; > - reset-names = "fe"; > - > - interrupt-parent = <&cpuintc>; > - interrupts = <5>; > - > - port@0 { > - compatible = "ralink,eth-port"; > - reg = <0>; > - phy-handle = <&phy0>; > - }; > - > -}; > diff --git a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt b/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > deleted file mode 100644 > index 87e315856efa..000000000000 > --- a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -Ralink Fast Ethernet Embedded Switch > -==================================== > - > -The ralink fast ethernet embedded switch can be found on Ralink and Mediatek > -SoCs (RT3x5x, RT5350, MT76x8). > - > -Required properties: > -- compatible: Should be "ralink,rt3050-esw" > -- reg: Address and length of the register set for the device > -- interrupts: Should contain the embedded switches interrupt > -- resets: Should contain the embedded switches resets > -- reset-names: Should contain the reset names "esw" > - > -Optional properties: > -- ralink,portmap: can be used to choose if the default switch setup is > - llllw or wllll > -- ralink,led_polarity: override the active high/low settings of the leds > - > -Example: > - > -esw@10110000 { > - compatible = "ralink,rt3050-esw"; > - reg = <0x10110000 8000>; > - > - resets = <&rstctrl 23>; > - reset-names = "esw"; > - > - interrupt-parent = <&intc>; > - interrupts = <17>; > -}; > -- > 2.31.1 >
Hi Rob, On Wed, Apr 21, 2021 at 3:03 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Apr 19, 2021 at 07:42:22PM -0700, Ilya Lipnitskiy wrote: > > Revert commit 663148e48a66 ("Documentation: DT: net: add docs for > > ralink/mediatek SoC ethernet binding") > > > > No in-tree drivers use the compatible strings present in these bindings, > > and some have been superseded by DSA-capable mtk_eth_soc driver, so > > remove these obsolete bindings. > > Looks like maybe OpenWRT folks are using these. If so, you can't revert > them. Indeed, there are out of tree drivers for some of these. I wasn't sure what the dt-binding policy was for such use cases - can you point me to a definitive reference? Ilya > > > > > Cc: John Crispin <john@phrozen.org> > > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> > > --- > > .../bindings/net/mediatek,mt7620-gsw.txt | 24 -------- > > .../bindings/net/ralink,rt2880-net.txt | 59 ------------------- > > .../bindings/net/ralink,rt3050-esw.txt | 30 ---------- > > 3 files changed, 113 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > > delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > > delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt b/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > > deleted file mode 100644 > > index 358fed2fab43..000000000000 > > --- a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Mediatek Gigabit Switch > > -======================= > > - > > -The mediatek gigabit switch can be found on Mediatek SoCs (mt7620, mt7621). > > - > > -Required properties: > > -- compatible: Should be "mediatek,mt7620-gsw" or "mediatek,mt7621-gsw" > > -- reg: Address and length of the register set for the device > > -- interrupts: Should contain the gigabit switches interrupt > > -- resets: Should contain the gigabit switches resets > > -- reset-names: Should contain the reset names "gsw" > > - > > -Example: > > - > > -gsw@10110000 { > > - compatible = "ralink,mt7620-gsw"; > > - reg = <0x10110000 8000>; > > - > > - resets = <&rstctrl 23>; > > - reset-names = "gsw"; > > - > > - interrupt-parent = <&intc>; > > - interrupts = <17>; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt b/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > > deleted file mode 100644 > > index 9fe1a0a22e44..000000000000 > > --- a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt > > +++ /dev/null > > @@ -1,59 +0,0 @@ > > -Ralink Frame Engine Ethernet controller > > -======================================= > > - > > -The Ralink frame engine ethernet controller can be found on Ralink and > > -Mediatek SoCs (RT288x, RT3x5x, RT366x, RT388x, rt5350, mt7620, mt7621, mt76x8). > > - > > -Depending on the SoC, there is a number of ports connected to the CPU port > > -directly and/or via a (gigabit-)switch. > > - > > -* Ethernet controller node > > - > > -Required properties: > > -- compatible: Should be one of "ralink,rt2880-eth", "ralink,rt3050-eth", > > - "ralink,rt3050-eth", "ralink,rt3883-eth", "ralink,rt5350-eth", > > - "mediatek,mt7620-eth", "mediatek,mt7621-eth" > > -- reg: Address and length of the register set for the device > > -- interrupts: Should contain the frame engines interrupt > > -- resets: Should contain the frame engines resets > > -- reset-names: Should contain the reset names "fe". If a switch is present > > - "esw" is also required. > > - > > - > > -* Ethernet port node > > - > > -Required properties: > > -- compatible: Should be "ralink,eth-port" > > -- reg: The number of the physical port > > -- phy-handle: reference to the node describing the phy > > - > > -Example: > > - > > -mdio-bus { > > - ... > > - phy0: ethernet-phy@0 { > > - phy-mode = "mii"; > > - reg = <0>; > > - }; > > -}; > > - > > -ethernet@400000 { > > - compatible = "ralink,rt2880-eth"; > > - reg = <0x00400000 10000>; > > - > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - resets = <&rstctrl 18>; > > - reset-names = "fe"; > > - > > - interrupt-parent = <&cpuintc>; > > - interrupts = <5>; > > - > > - port@0 { > > - compatible = "ralink,eth-port"; > > - reg = <0>; > > - phy-handle = <&phy0>; > > - }; > > - > > -}; > > diff --git a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt b/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > > deleted file mode 100644 > > index 87e315856efa..000000000000 > > --- a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt > > +++ /dev/null > > @@ -1,30 +0,0 @@ > > -Ralink Fast Ethernet Embedded Switch > > -==================================== > > - > > -The ralink fast ethernet embedded switch can be found on Ralink and Mediatek > > -SoCs (RT3x5x, RT5350, MT76x8). > > - > > -Required properties: > > -- compatible: Should be "ralink,rt3050-esw" > > -- reg: Address and length of the register set for the device > > -- interrupts: Should contain the embedded switches interrupt > > -- resets: Should contain the embedded switches resets > > -- reset-names: Should contain the reset names "esw" > > - > > -Optional properties: > > -- ralink,portmap: can be used to choose if the default switch setup is > > - llllw or wllll > > -- ralink,led_polarity: override the active high/low settings of the leds > > - > > -Example: > > - > > -esw@10110000 { > > - compatible = "ralink,rt3050-esw"; > > - reg = <0x10110000 8000>; > > - > > - resets = <&rstctrl 23>; > > - reset-names = "esw"; > > - > > - interrupt-parent = <&intc>; > > - interrupts = <17>; > > -}; > > -- > > 2.31.1 > >
On Wed, Apr 21, 2021 at 5:05 PM Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> wrote: > > Hi Rob, > > On Wed, Apr 21, 2021 at 3:03 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, Apr 19, 2021 at 07:42:22PM -0700, Ilya Lipnitskiy wrote: > > > Revert commit 663148e48a66 ("Documentation: DT: net: add docs for > > > ralink/mediatek SoC ethernet binding") > > > > > > No in-tree drivers use the compatible strings present in these bindings, > > > and some have been superseded by DSA-capable mtk_eth_soc driver, so > > > remove these obsolete bindings. > > > > Looks like maybe OpenWRT folks are using these. If so, you can't revert > > them. > Indeed, there are out of tree drivers for some of these. I wasn't sure > what the dt-binding policy was for such use cases - can you point me > to a definitive reference? Perhaps we should write that down more explicitly, but I think it is pretty rare actually. And really, I'd like to require we have at least 1 dts user. Though, then we'd just have dead dts files. More generally, other projects use the bindings and dts files. The bindings and dts files live in the kernel tree for convenience and the simple fact that is where the vast majority of both developers and hardware support are. There are exceptions of course such as h/w that doesn't run Linux. I'm all for removing this if no one cares (please try to find out) or if the existing binding is just bad (doesn't match the h/w or is incomplete in an incompatible way). I would have expected in the 5 years since it was added, a user (either dts file or driver) would have appeared. Rob
diff --git a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt b/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt deleted file mode 100644 index 358fed2fab43..000000000000 --- a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt +++ /dev/null @@ -1,24 +0,0 @@ -Mediatek Gigabit Switch -======================= - -The mediatek gigabit switch can be found on Mediatek SoCs (mt7620, mt7621). - -Required properties: -- compatible: Should be "mediatek,mt7620-gsw" or "mediatek,mt7621-gsw" -- reg: Address and length of the register set for the device -- interrupts: Should contain the gigabit switches interrupt -- resets: Should contain the gigabit switches resets -- reset-names: Should contain the reset names "gsw" - -Example: - -gsw@10110000 { - compatible = "ralink,mt7620-gsw"; - reg = <0x10110000 8000>; - - resets = <&rstctrl 23>; - reset-names = "gsw"; - - interrupt-parent = <&intc>; - interrupts = <17>; -}; diff --git a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt b/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt deleted file mode 100644 index 9fe1a0a22e44..000000000000 --- a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt +++ /dev/null @@ -1,59 +0,0 @@ -Ralink Frame Engine Ethernet controller -======================================= - -The Ralink frame engine ethernet controller can be found on Ralink and -Mediatek SoCs (RT288x, RT3x5x, RT366x, RT388x, rt5350, mt7620, mt7621, mt76x8). - -Depending on the SoC, there is a number of ports connected to the CPU port -directly and/or via a (gigabit-)switch. - -* Ethernet controller node - -Required properties: -- compatible: Should be one of "ralink,rt2880-eth", "ralink,rt3050-eth", - "ralink,rt3050-eth", "ralink,rt3883-eth", "ralink,rt5350-eth", - "mediatek,mt7620-eth", "mediatek,mt7621-eth" -- reg: Address and length of the register set for the device -- interrupts: Should contain the frame engines interrupt -- resets: Should contain the frame engines resets -- reset-names: Should contain the reset names "fe". If a switch is present - "esw" is also required. - - -* Ethernet port node - -Required properties: -- compatible: Should be "ralink,eth-port" -- reg: The number of the physical port -- phy-handle: reference to the node describing the phy - -Example: - -mdio-bus { - ... - phy0: ethernet-phy@0 { - phy-mode = "mii"; - reg = <0>; - }; -}; - -ethernet@400000 { - compatible = "ralink,rt2880-eth"; - reg = <0x00400000 10000>; - - #address-cells = <1>; - #size-cells = <0>; - - resets = <&rstctrl 18>; - reset-names = "fe"; - - interrupt-parent = <&cpuintc>; - interrupts = <5>; - - port@0 { - compatible = "ralink,eth-port"; - reg = <0>; - phy-handle = <&phy0>; - }; - -}; diff --git a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt b/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt deleted file mode 100644 index 87e315856efa..000000000000 --- a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt +++ /dev/null @@ -1,30 +0,0 @@ -Ralink Fast Ethernet Embedded Switch -==================================== - -The ralink fast ethernet embedded switch can be found on Ralink and Mediatek -SoCs (RT3x5x, RT5350, MT76x8). - -Required properties: -- compatible: Should be "ralink,rt3050-esw" -- reg: Address and length of the register set for the device -- interrupts: Should contain the embedded switches interrupt -- resets: Should contain the embedded switches resets -- reset-names: Should contain the reset names "esw" - -Optional properties: -- ralink,portmap: can be used to choose if the default switch setup is - llllw or wllll -- ralink,led_polarity: override the active high/low settings of the leds - -Example: - -esw@10110000 { - compatible = "ralink,rt3050-esw"; - reg = <0x10110000 8000>; - - resets = <&rstctrl 23>; - reset-names = "esw"; - - interrupt-parent = <&intc>; - interrupts = <17>; -};
Revert commit 663148e48a66 ("Documentation: DT: net: add docs for ralink/mediatek SoC ethernet binding") No in-tree drivers use the compatible strings present in these bindings, and some have been superseded by DSA-capable mtk_eth_soc driver, so remove these obsolete bindings. Cc: John Crispin <john@phrozen.org> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> --- .../bindings/net/mediatek,mt7620-gsw.txt | 24 -------- .../bindings/net/ralink,rt2880-net.txt | 59 ------------------- .../bindings/net/ralink,rt3050-esw.txt | 30 ---------- 3 files changed, 113 deletions(-) delete mode 100644 Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt2880-net.txt delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt