| Message ID | 20210426184201.4177978-9-krisman@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | File system wide monitoring | expand |
On Mon, Apr 26, 2021 at 9:42 PM Gabriel Krisman Bertazi <krisman@collabora.com> wrote: > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> > --- > include/linux/fsnotify.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h > index f8acddcf54fb..b3ac1a9d0d4d 100644 > --- a/include/linux/fsnotify.h > +++ b/include/linux/fsnotify.h > @@ -317,4 +317,19 @@ static inline void fsnotify_change(struct dentry *dentry, unsigned int ia_valid) > fsnotify_dentry(dentry, mask); > } > > +static inline void fsnotify_error_event(int error, struct inode *dir, > + const char *function, int line, > + void *fs_data, int fs_data_size) > +{ > + struct fs_error_report report = { > + .error = error, > + .line = line, > + .function = function, > + .fs_data_size = fs_data_size, > + .fs_data = fs_data, > + }; > + > + fsnotify(FS_ERROR, &report, FSNOTIFY_EVENT_ERROR, dir, NULL, NULL, 0); The way you use this helper from ext4_fsnotify_error() it would make more sense to name the inode argument 'inode' and call: fsnotify(FS_ERROR, &report, FSNOTIFY_EVENT_ERROR, NULL, NULL, inode, 0); Also, if we stick with returning ENOMEM instead of overflow event (I don't think we should), then this helper should return the error as well. Thanks, Amir.
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h index f8acddcf54fb..b3ac1a9d0d4d 100644 --- a/include/linux/fsnotify.h +++ b/include/linux/fsnotify.h @@ -317,4 +317,19 @@ static inline void fsnotify_change(struct dentry *dentry, unsigned int ia_valid) fsnotify_dentry(dentry, mask); } +static inline void fsnotify_error_event(int error, struct inode *dir, + const char *function, int line, + void *fs_data, int fs_data_size) +{ + struct fs_error_report report = { + .error = error, + .line = line, + .function = function, + .fs_data_size = fs_data_size, + .fs_data = fs_data, + }; + + fsnotify(FS_ERROR, &report, FSNOTIFY_EVENT_ERROR, dir, NULL, NULL, 0); +} + #endif /* _LINUX_FS_NOTIFY_H */
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> --- include/linux/fsnotify.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)