| Message ID | 3d3b733c31273a004e80d5cbab8f746a2010e9ea.1618829583.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Prepare tests for reftable backend | expand |
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Han-Wen Nienhuys <hanwen@google.com> > > REFFILES can be used to mark tests that are specific to the packed/loose ref > storage format and its limitations. Marking such tests is a preparation for > introducing the reftable storage backend. We'd want a bit of documentation either here or in t/README to explain things like how these two interact with each other, if both can be active at the same time, etc. > > Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> > --- > t/test-lib.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/t/test-lib.sh b/t/test-lib.sh > index d3f6af6a6545..ea7397c633db 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -1481,6 +1481,8 @@ parisc* | hppa*) > ;; > esac > > +test_set_prereq REFFILES > + > ( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1 > test -z "$NO_PERL" && test_set_prereq PERL > test -z "$NO_PTHREADS" && test_set_prereq PTHREADS
Junio C Hamano <gitster@pobox.com> writes: > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> From: Han-Wen Nienhuys <hanwen@google.com> >> >> REFFILES can be used to mark tests that are specific to the packed/loose ref >> storage format and its limitations. Marking such tests is a preparation for >> introducing the reftable storage backend. > > We'd want a bit of documentation either here or in t/README to > explain things like how these two interact with each other, if both > can be active at the same time, etc. By "here", I meant the place in the code where the test_set_prereq was added, not in the proposed log message that will become hard to see when test writers need to work with the sources. Thanks. > >> >> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> >> --- >> t/test-lib.sh | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/t/test-lib.sh b/t/test-lib.sh >> index d3f6af6a6545..ea7397c633db 100644 >> --- a/t/test-lib.sh >> +++ b/t/test-lib.sh >> @@ -1481,6 +1481,8 @@ parisc* | hppa*) >> ;; >> esac >> >> +test_set_prereq REFFILES >> + >> ( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1 >> test -z "$NO_PERL" && test_set_prereq PERL >> test -z "$NO_PTHREADS" && test_set_prereq PTHREADS
On Wed, Apr 21, 2021 at 1:37 AM Junio C Hamano <gitster@pobox.com> wrote: > > Junio C Hamano <gitster@pobox.com> writes: > > > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > >> From: Han-Wen Nienhuys <hanwen@google.com> > >> > >> REFFILES can be used to mark tests that are specific to the packed/loose ref > >> storage format and its limitations. Marking such tests is a preparation for > >> introducing the reftable storage backend. > > > > We'd want a bit of documentation either here or in t/README to > > explain things like how these two interact with each other, if both > > can be active at the same time, etc. > > By "here", I meant the place in the code where the test_set_prereq > was added, not in the proposed log message that will become hard to > see when test writers need to work with the sources. But this doc would be part of the reftable series, not this series, right?
On Wed, Apr 21, 2021 at 12:57 AM Junio C Hamano <gitster@pobox.com> wrote: > > REFFILES can be used to mark tests that are specific to the packed/loose ref > > storage format and its limitations. Marking such tests is a preparation for > > introducing the reftable storage backend. > > We'd want a bit of documentation either here or in t/README to > explain things like how these two interact with each other, if both > can be active at the same time, etc. Documented the prereq in README.
diff --git a/t/test-lib.sh b/t/test-lib.sh index d3f6af6a6545..ea7397c633db 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1481,6 +1481,8 @@ parisc* | hppa*) ;; esac +test_set_prereq REFFILES + ( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1 test -z "$NO_PERL" && test_set_prereq PERL test -z "$NO_PTHREADS" && test_set_prereq PTHREADS