| Message ID | 20210429062130.29403-5-dqfext@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | MT7530 interrupt support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: linux-arm-kernel@lists.infradead.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: line length of 81 exceeds 80 columns |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
On Thu, Apr 29, 2021 at 02:21:30PM +0800, DENG Qingfang wrote: > Enable MT7530 interrupt controller in the MT7621 SoC. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 4/28/2021 11:21 PM, DENG Qingfang wrote: > Enable MT7530 interrupt controller in the MT7621 SoC. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Thu, Apr 29, 2021 at 02:21:30PM +0800, DENG Qingfang wrote: > Enable MT7530 interrupt controller in the MT7621 SoC. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> > --- > RFC v4 -> PATCH v1: > - No changes. > > drivers/staging/mt7621-dts/mt7621.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi > index 16fc94f65486..0f7e487883a5 100644 > --- a/drivers/staging/mt7621-dts/mt7621.dtsi > +++ b/drivers/staging/mt7621-dts/mt7621.dtsi > @@ -447,6 +447,10 @@ switch0: switch0@0 { > mediatek,mcm; > resets = <&rstctrl 2>; > reset-names = "mcm"; > + interrupt-controller; > + #interrupt-cells = <1>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>; > > ports { > #address-cells = <1>; > -- > 2.25.1 > I don't remember if I mentioned this before, but a short-hand way of expressing this is using: interrupts-extended = <&gic GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>; but the entire drivers/staging/mt7621-dts/mt7621.dtsi file uses interrupt-parent, so this is fine. Also, I panicked for a second thinking that this is the ARM GIC which supports the GIC_SHARED flag, but I see that mt7621 is MIPS. Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi index 16fc94f65486..0f7e487883a5 100644 --- a/drivers/staging/mt7621-dts/mt7621.dtsi +++ b/drivers/staging/mt7621-dts/mt7621.dtsi @@ -447,6 +447,10 @@ switch0: switch0@0 { mediatek,mcm; resets = <&rstctrl 2>; reset-names = "mcm"; + interrupt-controller; + #interrupt-cells = <1>; + interrupt-parent = <&gic>; + interrupts = <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>; ports { #address-cells = <1>;
Enable MT7530 interrupt controller in the MT7621 SoC. Signed-off-by: DENG Qingfang <dqfext@gmail.com> --- RFC v4 -> PATCH v1: - No changes. drivers/staging/mt7621-dts/mt7621.dtsi | 4 ++++ 1 file changed, 4 insertions(+)