[v4,0/7] clk: st: embed clock outputs within drivers

Message

Alain Volmat March 31, 2021, 8:16 p.m. UTC

Most of ST clock drivers used by STi platform are updated in
order to introduce clock outputs informations within each drivers
and thus allow to avoid having to rely on clock-output-names properties
within DT clock nodes.
For that purpose, drivers are updated to allow handling both modes
(with or without clock-output-names).
Once all DT will have been updated, the legacy mode could be removed
from the drivers.
This will also allow, once all STi DT will be corrected, to remove the
of_clk_detect_critical API from clk core code since STi clock drivers
are the only drivers using this API.

Alain Volmat (7):
  clk: st: clkgen-pll: remove unused variable of struct clkgen_pll
  clk: st: flexgen: embed soc clock outputs within compatible data
  dt-bindings: clock: st: flexgen: add new introduced compatible
  clk: st: clkgen-pll: embed soc clock outputs within compatible data
  dt-bindings: clock: st: clkgen-pll: add new introduced compatible
  clk: st: clkgen-fsyn: embed soc clock outputs within compatible data
  dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible

 .../bindings/clock/st/st,clkgen-pll.txt       |   3 +
 .../bindings/clock/st/st,flexgen.txt          |  10 +
 .../bindings/clock/st/st,quadfs.txt           |   3 +
 drivers/clk/st/clk-flexgen.c                  | 367 +++++++++++++++++-
 drivers/clk/st/clkgen-fsyn.c                  | 113 +++++-
 drivers/clk/st/clkgen-pll.c                   | 121 +++++-
 6 files changed, 576 insertions(+), 41 deletions(-)

---
v4: - add an additional CLK_IS_CRITICAL within flexgen driver
v3: - removal some useless CLK_IS_CRITICAL and add some comments
    - only keep clk drivers/binding patches within the serie

Comments

Alain Volmat April 30, 2021, 4:48 p.m. UTC | #1

Hi,

Gentle reminder about this serie concerning STi platform clock drivers.
Could you have a look at them ?

Thanks.
Alain

On Wed, Mar 31, 2021 at 10:16:25PM +0200, Alain Volmat wrote:
> Most of ST clock drivers used by STi platform are updated in
> order to introduce clock outputs informations within each drivers
> and thus allow to avoid having to rely on clock-output-names properties
> within DT clock nodes.
> For that purpose, drivers are updated to allow handling both modes
> (with or without clock-output-names).
> Once all DT will have been updated, the legacy mode could be removed
> from the drivers.
> This will also allow, once all STi DT will be corrected, to remove the
> of_clk_detect_critical API from clk core code since STi clock drivers
> are the only drivers using this API.
> 
> Alain Volmat (7):
>   clk: st: clkgen-pll: remove unused variable of struct clkgen_pll
>   clk: st: flexgen: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: flexgen: add new introduced compatible
>   clk: st: clkgen-pll: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: clkgen-pll: add new introduced compatible
>   clk: st: clkgen-fsyn: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible
> 
>  .../bindings/clock/st/st,clkgen-pll.txt       |   3 +
>  .../bindings/clock/st/st,flexgen.txt          |  10 +
>  .../bindings/clock/st/st,quadfs.txt           |   3 +
>  drivers/clk/st/clk-flexgen.c                  | 367 +++++++++++++++++-
>  drivers/clk/st/clkgen-fsyn.c                  | 113 +++++-
>  drivers/clk/st/clkgen-pll.c                   | 121 +++++-
>  6 files changed, 576 insertions(+), 41 deletions(-)
> 
> ---
> v4: - add an additional CLK_IS_CRITICAL within flexgen driver
> v3: - removal some useless CLK_IS_CRITICAL and add some comments
>     - only keep clk drivers/binding patches within the serie
> 
> -- 
> 2.17.1
>

Alain Volmat June 17, 2021, 8:28 p.m. UTC | #2

Hi Stephen,

gentle reminder about this serie. Patrick and Rob have given their
Reviewed-by already. Could you have a look at it ?

Thanks.
Alain

On Fri, Apr 30, 2021 at 06:48:30PM +0200, Alain Volmat wrote:
> Hi,
> 
> Gentle reminder about this serie concerning STi platform clock drivers.
> Could you have a look at them ?
> 
> Thanks.
> Alain
> 
> On Wed, Mar 31, 2021 at 10:16:25PM +0200, Alain Volmat wrote:
> > Most of ST clock drivers used by STi platform are updated in
> > order to introduce clock outputs informations within each drivers
> > and thus allow to avoid having to rely on clock-output-names properties
> > within DT clock nodes.
> > For that purpose, drivers are updated to allow handling both modes
> > (with or without clock-output-names).
> > Once all DT will have been updated, the legacy mode could be removed
> > from the drivers.
> > This will also allow, once all STi DT will be corrected, to remove the
> > of_clk_detect_critical API from clk core code since STi clock drivers
> > are the only drivers using this API.
> > 
> > Alain Volmat (7):
> >   clk: st: clkgen-pll: remove unused variable of struct clkgen_pll
> >   clk: st: flexgen: embed soc clock outputs within compatible data
> >   dt-bindings: clock: st: flexgen: add new introduced compatible
> >   clk: st: clkgen-pll: embed soc clock outputs within compatible data
> >   dt-bindings: clock: st: clkgen-pll: add new introduced compatible
> >   clk: st: clkgen-fsyn: embed soc clock outputs within compatible data
> >   dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible
> > 
> >  .../bindings/clock/st/st,clkgen-pll.txt       |   3 +
> >  .../bindings/clock/st/st,flexgen.txt          |  10 +
> >  .../bindings/clock/st/st,quadfs.txt           |   3 +
> >  drivers/clk/st/clk-flexgen.c                  | 367 +++++++++++++++++-
> >  drivers/clk/st/clkgen-fsyn.c                  | 113 +++++-
> >  drivers/clk/st/clkgen-pll.c                   | 121 +++++-
> >  6 files changed, 576 insertions(+), 41 deletions(-)
> > 
> > ---
> > v4: - add an additional CLK_IS_CRITICAL within flexgen driver
> > v3: - removal some useless CLK_IS_CRITICAL and add some comments
> >     - only keep clk drivers/binding patches within the serie
> > 
> > -- 
> > 2.17.1
> > 
>

Stephen Boyd June 28, 2021, 2:54 a.m. UTC | #3

Quoting Alain Volmat (2021-03-31 13:16:25)
> Most of ST clock drivers used by STi platform are updated in
> order to introduce clock outputs informations within each drivers
> and thus allow to avoid having to rely on clock-output-names properties
> within DT clock nodes.
> For that purpose, drivers are updated to allow handling both modes
> (with or without clock-output-names).
> Once all DT will have been updated, the legacy mode could be removed
> from the drivers.
> This will also allow, once all STi DT will be corrected, to remove the
> of_clk_detect_critical API from clk core code since STi clock drivers
> are the only drivers using this API.
> 
> Alain Volmat (7):
>   clk: st: clkgen-pll: remove unused variable of struct clkgen_pll
>   clk: st: flexgen: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: flexgen: add new introduced compatible
>   clk: st: clkgen-pll: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: clkgen-pll: add new introduced compatible
>   clk: st: clkgen-fsyn: embed soc clock outputs within compatible data
>   dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible
> 
>  .../bindings/clock/st/st,clkgen-pll.txt       |   3 +
>  .../bindings/clock/st/st,flexgen.txt          |  10 +
>  .../bindings/clock/st/st,quadfs.txt           |   3 +
>  drivers/clk/st/clk-flexgen.c                  | 367 +++++++++++++++++-
>  drivers/clk/st/clkgen-fsyn.c                  | 113 +++++-
>  drivers/clk/st/clkgen-pll.c                   | 121 +++++-
>  6 files changed, 576 insertions(+), 41 deletions(-)
> 
> ---

Please don't do this triple dash. It made me have to run git am --skip
on this mbox because git thought this was a patch.

> v4: - add an additional CLK_IS_CRITICAL within flexgen driver
> v3: - removal some useless CLK_IS_CRITICAL and add some comments
>     - only keep clk drivers/binding patches within the serie
>