| Message ID | 20210503102323.17804-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ibmvnic: remove default label from to_string switch | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 10 of 10 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 3 this patch: 3 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 20 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote: > > This way the compiler warns when a new value is added to the enum but > not the string transation like: s/transation/translation/ This trick works. Since the original code does not generate gcc warnings/errors, should this patch be sent to net-next as an improvement? > > drivers/net/ethernet/ibm/ibmvnic.c: In function 'adapter_state_to_string': > drivers/net/ethernet/ibm/ibmvnic.c:832:2: warning: enumeration value 'VNIC_FOOBAR' not handled in switch [-Wswitch] > switch (state) { > ^~~~~~ > drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string': > drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch] > switch (reason) { > ^~~~~~ > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > --- Acked-by: Lijun Pan <lijunp213@gmail.com> > drivers/net/ethernet/ibm/ibmvnic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index 5788bb956d73..4d439413f6d9 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -846,9 +846,8 @@ static const char *adapter_state_to_string(enum vnic_state state) > return "REMOVING"; > case VNIC_REMOVED: > return "REMOVED"; > - default: > - return "UNKNOWN"; > } > + return "UNKNOWN"; > } > > static int ibmvnic_login(struct net_device *netdev) > @@ -1946,9 +1945,8 @@ static const char *reset_reason_to_string(enum ibmvnic_reset_reason reason) > return "TIMEOUT"; > case VNIC_RESET_CHANGE_PARAM: > return "CHANGE_PARAM"; > - default: > - return "UNKNOWN"; > } > + return "UNKNOWN"; > } > > /* > -- > 2.26.2 >
From: Lijun Pan <lijunp213@gmail.com> Date: Mon, 3 May 2021 13:21:00 -0500 > On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote: >> >> This way the compiler warns when a new value is added to the enum but >> not the string transation like: > > s/transation/translation/ > > This trick works. > Since the original code does not generate gcc warnings/errors, should > this patch be sent to net-next as an improvement? Yes.
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 5788bb956d73..4d439413f6d9 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -846,9 +846,8 @@ static const char *adapter_state_to_string(enum vnic_state state) return "REMOVING"; case VNIC_REMOVED: return "REMOVED"; - default: - return "UNKNOWN"; } + return "UNKNOWN"; } static int ibmvnic_login(struct net_device *netdev) @@ -1946,9 +1945,8 @@ static const char *reset_reason_to_string(enum ibmvnic_reset_reason reason) return "TIMEOUT"; case VNIC_RESET_CHANGE_PARAM: return "CHANGE_PARAM"; - default: - return "UNKNOWN"; } + return "UNKNOWN"; } /*
This way the compiler warns when a new value is added to the enum but not the string transation like: drivers/net/ethernet/ibm/ibmvnic.c: In function 'adapter_state_to_string': drivers/net/ethernet/ibm/ibmvnic.c:832:2: warning: enumeration value 'VNIC_FOOBAR' not handled in switch [-Wswitch] switch (state) { ^~~~~~ drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string': drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch] switch (reason) { ^~~~~~ Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- drivers/net/ethernet/ibm/ibmvnic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)