| Message ID | 20210504100545.112213-1-dgilbert@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/migration-test: Fix "true" vs true | expand |
On 04/05/2021 12.05, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Accidental use of "true" as a boolean; spotted by coverity > and Peter. > > Fixes: b99784ef6c3 > Fixes: d795f47466e > Reported-by: Peter Maydell <peter.maydell@linaro.org> > Reported-by: Coverity (CID 1432373, 1432292, 1432288) > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > tests/qtest/migration-test.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 3a711bb492..4d989f191b 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri) > > migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432); > > - migrate_set_capability(from, "xbzrle", "true"); > - migrate_set_capability(to, "xbzrle", "true"); > + migrate_set_capability(from, "xbzrle", true); > + migrate_set_capability(to, "xbzrle", true); > /* Wait for the first serial output from the source */ > wait_for_serial("src_serial"); > > @@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method) > migrate_set_parameter_str(from, "multifd-compression", method); > migrate_set_parameter_str(to, "multifd-compression", method); > > - migrate_set_capability(from, "multifd", "true"); > - migrate_set_capability(to, "multifd", "true"); > + migrate_set_capability(from, "multifd", true); > + migrate_set_capability(to, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," > @@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void) > migrate_set_parameter_int(from, "multifd-channels", 16); > migrate_set_parameter_int(to, "multifd-channels", 16); > > - migrate_set_capability(from, "multifd", "true"); > - migrate_set_capability(to, "multifd", "true"); > + migrate_set_capability(from, "multifd", true); > + migrate_set_capability(to, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," > @@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void) > > migrate_set_parameter_int(to2, "multifd-channels", 16); > > - migrate_set_capability(to2, "multifd", "true"); > + migrate_set_capability(to2, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to2, "{ 'execute': 'migrate-incoming'," > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 5/4/21 12:05 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Accidental use of "true" as a boolean; spotted by coverity > and Peter. > > Fixes: b99784ef6c3 > Fixes: d795f47466e > Reported-by: Peter Maydell <peter.maydell@linaro.org> > Reported-by: Coverity (CID 1432373, 1432292, 1432288) > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > tests/qtest/migration-test.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 3a711bb492..4d989f191b 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri) > > migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432); > > - migrate_set_capability(from, "xbzrle", "true"); > - migrate_set_capability(to, "xbzrle", "true"); > + migrate_set_capability(from, "xbzrle", true); > + migrate_set_capability(to, "xbzrle", true); Funny one =) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > Accidental use of "true" as a boolean; spotted by coverity > and Peter. > > Fixes: b99784ef6c3 > Fixes: d795f47466e > Reported-by: Peter Maydell <peter.maydell@linaro.org> > Reported-by: Coverity (CID 1432373, 1432292, 1432288) > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Queued > --- > tests/qtest/migration-test.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 3a711bb492..4d989f191b 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri) > > migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432); > > - migrate_set_capability(from, "xbzrle", "true"); > - migrate_set_capability(to, "xbzrle", "true"); > + migrate_set_capability(from, "xbzrle", true); > + migrate_set_capability(to, "xbzrle", true); > /* Wait for the first serial output from the source */ > wait_for_serial("src_serial"); > > @@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method) > migrate_set_parameter_str(from, "multifd-compression", method); > migrate_set_parameter_str(to, "multifd-compression", method); > > - migrate_set_capability(from, "multifd", "true"); > - migrate_set_capability(to, "multifd", "true"); > + migrate_set_capability(from, "multifd", true); > + migrate_set_capability(to, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," > @@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void) > migrate_set_parameter_int(from, "multifd-channels", 16); > migrate_set_parameter_int(to, "multifd-channels", 16); > > - migrate_set_capability(from, "multifd", "true"); > - migrate_set_capability(to, "multifd", "true"); > + migrate_set_capability(from, "multifd", true); > + migrate_set_capability(to, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," > @@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void) > > migrate_set_parameter_int(to2, "multifd-channels", 16); > > - migrate_set_capability(to2, "multifd", "true"); > + migrate_set_capability(to2, "multifd", true); > > /* Start incoming migration from the 1st socket */ > rsp = wait_command(to2, "{ 'execute': 'migrate-incoming'," > -- > 2.31.1 > >
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3a711bb492..4d989f191b 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri) migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432); - migrate_set_capability(from, "xbzrle", "true"); - migrate_set_capability(to, "xbzrle", "true"); + migrate_set_capability(from, "xbzrle", true); + migrate_set_capability(to, "xbzrle", true); /* Wait for the first serial output from the source */ wait_for_serial("src_serial"); @@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method) migrate_set_parameter_str(from, "multifd-compression", method); migrate_set_parameter_str(to, "multifd-compression", method); - migrate_set_capability(from, "multifd", "true"); - migrate_set_capability(to, "multifd", "true"); + migrate_set_capability(from, "multifd", true); + migrate_set_capability(to, "multifd", true); /* Start incoming migration from the 1st socket */ rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," @@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void) migrate_set_parameter_int(from, "multifd-channels", 16); migrate_set_parameter_int(to, "multifd-channels", 16); - migrate_set_capability(from, "multifd", "true"); - migrate_set_capability(to, "multifd", "true"); + migrate_set_capability(from, "multifd", true); + migrate_set_capability(to, "multifd", true); /* Start incoming migration from the 1st socket */ rsp = wait_command(to, "{ 'execute': 'migrate-incoming'," @@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void) migrate_set_parameter_int(to2, "multifd-channels", 16); - migrate_set_capability(to2, "multifd", "true"); + migrate_set_capability(to2, "multifd", true); /* Start incoming migration from the 1st socket */ rsp = wait_command(to2, "{ 'execute': 'migrate-incoming',"