mbox series

[v7,0/5] Enable root to update the blacklist keyring

Message ID 20210312171232.2681989-1-mic@digikod.net (mailing list archive)
Headers show
Series Enable root to update the blacklist keyring | expand

Message

Mickaël Salaün March 12, 2021, 5:12 p.m. UTC
This new patch series is a rebase on David Howells's and Eric Snowberg's
keys-cve-2020-26541-v3.

I successfully tested this patch series with the 186 entries from
https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184
binary hashes and 2 certificates).

The goal of these patches is to add a new configuration option to enable the
root user to load signed keys in the blacklist keyring.  This keyring is useful
to "untrust" certificates or files.  Enabling to safely update this keyring
without recompiling the kernel makes it more usable.

This can be applied on top of David Howells's keys-cve-2020-26541-branch:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch

Previous patch series:
https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/

Regards,

Mickaël Salaün (5):
  tools/certs: Add print-cert-tbs-hash.sh
  certs: Check that builtin blacklist hashes are valid
  certs: Make blacklist_vet_description() more strict
  certs: Factor out the blacklist hash creation
  certs: Allow root user to append signed hashes to the blacklist
    keyring

 MAINTAINERS                                   |   2 +
 certs/.gitignore                              |   1 +
 certs/Kconfig                                 |  17 +-
 certs/Makefile                                |  17 +-
 certs/blacklist.c                             | 218 ++++++++++++++----
 crypto/asymmetric_keys/x509_public_key.c      |   3 +-
 include/keys/system_keyring.h                 |  14 +-
 scripts/check-blacklist-hashes.awk            |  37 +++
 .../platform_certs/keyring_handler.c          |  26 +--
 tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
 10 files changed, 346 insertions(+), 80 deletions(-)
 create mode 100755 scripts/check-blacklist-hashes.awk
 create mode 100755 tools/certs/print-cert-tbs-hash.sh


base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b

Comments

Mickaël Salaün March 25, 2021, 11:36 a.m. UTC | #1
Hi David,

What is the status of this patchset? Could you please push it to -next?

Regards,
 Mickaël

On 12/03/2021 18:12, Mickaël Salaün wrote:
> This new patch series is a rebase on David Howells's and Eric Snowberg's
> keys-cve-2020-26541-v3.
> 
> I successfully tested this patch series with the 186 entries from
> https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184
> binary hashes and 2 certificates).
> 
> The goal of these patches is to add a new configuration option to enable the
> root user to load signed keys in the blacklist keyring.  This keyring is useful
> to "untrust" certificates or files.  Enabling to safely update this keyring
> without recompiling the kernel makes it more usable.
> 
> This can be applied on top of David Howells's keys-cve-2020-26541-branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch
> 
> Previous patch series:
> https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/
> 
> Regards,
> 
> Mickaël Salaün (5):
>   tools/certs: Add print-cert-tbs-hash.sh
>   certs: Check that builtin blacklist hashes are valid
>   certs: Make blacklist_vet_description() more strict
>   certs: Factor out the blacklist hash creation
>   certs: Allow root user to append signed hashes to the blacklist
>     keyring
> 
>  MAINTAINERS                                   |   2 +
>  certs/.gitignore                              |   1 +
>  certs/Kconfig                                 |  17 +-
>  certs/Makefile                                |  17 +-
>  certs/blacklist.c                             | 218 ++++++++++++++----
>  crypto/asymmetric_keys/x509_public_key.c      |   3 +-
>  include/keys/system_keyring.h                 |  14 +-
>  scripts/check-blacklist-hashes.awk            |  37 +++
>  .../platform_certs/keyring_handler.c          |  26 +--
>  tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
>  10 files changed, 346 insertions(+), 80 deletions(-)
>  create mode 100755 scripts/check-blacklist-hashes.awk
>  create mode 100755 tools/certs/print-cert-tbs-hash.sh
> 
> 
> base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b
>
Mickaël Salaün April 7, 2021, 5:21 p.m. UTC | #2
Hi David and Jarkko,

What is the status of this patchset? Could someone take it to -next?

Regards,
 Mickaël


On 12/03/2021 18:12, Mickaël Salaün wrote:
> This new patch series is a rebase on David Howells's and Eric Snowberg's
> keys-cve-2020-26541-v3.
> 
> I successfully tested this patch series with the 186 entries from
> https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184
> binary hashes and 2 certificates).
> 
> The goal of these patches is to add a new configuration option to enable the
> root user to load signed keys in the blacklist keyring.  This keyring is useful
> to "untrust" certificates or files.  Enabling to safely update this keyring
> without recompiling the kernel makes it more usable.
> 
> This can be applied on top of David Howells's keys-cve-2020-26541-branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch
> 
> Previous patch series:
> https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/
> 
> Regards,
> 
> Mickaël Salaün (5):
>   tools/certs: Add print-cert-tbs-hash.sh
>   certs: Check that builtin blacklist hashes are valid
>   certs: Make blacklist_vet_description() more strict
>   certs: Factor out the blacklist hash creation
>   certs: Allow root user to append signed hashes to the blacklist
>     keyring
> 
>  MAINTAINERS                                   |   2 +
>  certs/.gitignore                              |   1 +
>  certs/Kconfig                                 |  17 +-
>  certs/Makefile                                |  17 +-
>  certs/blacklist.c                             | 218 ++++++++++++++----
>  crypto/asymmetric_keys/x509_public_key.c      |   3 +-
>  include/keys/system_keyring.h                 |  14 +-
>  scripts/check-blacklist-hashes.awk            |  37 +++
>  .../platform_certs/keyring_handler.c          |  26 +--
>  tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
>  10 files changed, 346 insertions(+), 80 deletions(-)
>  create mode 100755 scripts/check-blacklist-hashes.awk
>  create mode 100755 tools/certs/print-cert-tbs-hash.sh
> 
> 
> base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b
>
Mickaël Salaün May 4, 2021, 10:31 a.m. UTC | #3
Are you waiting for the end of the merge window to push to linux-next?

On 07/04/2021 19:21, Mickaël Salaün wrote:
> Hi David and Jarkko,
> 
> What is the status of this patchset? Could someone take it to -next?
> 
> Regards,
>  Mickaël
> 
> 
> On 12/03/2021 18:12, Mickaël Salaün wrote:
>> This new patch series is a rebase on David Howells's and Eric Snowberg's
>> keys-cve-2020-26541-v3.
>>
>> I successfully tested this patch series with the 186 entries from
>> https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184
>> binary hashes and 2 certificates).
>>
>> The goal of these patches is to add a new configuration option to enable the
>> root user to load signed keys in the blacklist keyring.  This keyring is useful
>> to "untrust" certificates or files.  Enabling to safely update this keyring
>> without recompiling the kernel makes it more usable.
>>
>> This can be applied on top of David Howells's keys-cve-2020-26541-branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch
>>
>> Previous patch series:
>> https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/
>>
>> Regards,
>>
>> Mickaël Salaün (5):
>>   tools/certs: Add print-cert-tbs-hash.sh
>>   certs: Check that builtin blacklist hashes are valid
>>   certs: Make blacklist_vet_description() more strict
>>   certs: Factor out the blacklist hash creation
>>   certs: Allow root user to append signed hashes to the blacklist
>>     keyring
>>
>>  MAINTAINERS                                   |   2 +
>>  certs/.gitignore                              |   1 +
>>  certs/Kconfig                                 |  17 +-
>>  certs/Makefile                                |  17 +-
>>  certs/blacklist.c                             | 218 ++++++++++++++----
>>  crypto/asymmetric_keys/x509_public_key.c      |   3 +-
>>  include/keys/system_keyring.h                 |  14 +-
>>  scripts/check-blacklist-hashes.awk            |  37 +++
>>  .../platform_certs/keyring_handler.c          |  26 +--
>>  tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
>>  10 files changed, 346 insertions(+), 80 deletions(-)
>>  create mode 100755 scripts/check-blacklist-hashes.awk
>>  create mode 100755 tools/certs/print-cert-tbs-hash.sh
>>
>>
>> base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b
>>