| Message ID | 20210504124842.220445-8-jandryuk@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | vtpmmgr: Some fixes - still incomplete | expand |
Jason Andryuk, le mar. 04 mai 2021 08:48:40 -0400, a ecrit: > We're only flushing 2 transients, but there are 3 handles. Use <= to also > flush the third handle. > > The number of transient handles/keys is hardware dependent, so this > should query for the limit. And assignment of handles is assumed to be > sequential from the minimum. That may not be guaranteed, but seems okay > with my tpm2. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> Maybe explicit in the log that TRANSIENT_LAST is actually inclusive? Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> > --- > stubdom/vtpmmgr/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c > index d9fefa9be6..e0dbcac3ad 100644 > --- a/stubdom/vtpmmgr/init.c > +++ b/stubdom/vtpmmgr/init.c > @@ -656,7 +656,7 @@ static TPM_RC flush_tpm2(void) > { > int i; > > - for (i = TRANSIENT_FIRST; i < TRANSIENT_LAST; i++) > + for (i = TRANSIENT_FIRST; i <= TRANSIENT_LAST; i++) > TPM2_FlushContext(i); > > return TPM_SUCCESS; > -- > 2.30.2 >
On Tue, May 4, 2021 at 9:16 AM Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > > Jason Andryuk, le mar. 04 mai 2021 08:48:40 -0400, a ecrit: > > We're only flushing 2 transients, but there are 3 handles. Use <= to also > > flush the third handle. > > > > The number of transient handles/keys is hardware dependent, so this > > should query for the limit. And assignment of handles is assumed to be > > sequential from the minimum. That may not be guaranteed, but seems okay > > with my tpm2. > > > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> > > Maybe explicit in the log that TRANSIENT_LAST is actually inclusive? In the commit message? Sounds good to me. > Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Thanks, Jason
Jason Andryuk, le mar. 04 mai 2021 13:05:33 -0400, a ecrit: > On Tue, May 4, 2021 at 9:16 AM Samuel Thibault > <samuel.thibault@ens-lyon.org> wrote: > > > > Jason Andryuk, le mar. 04 mai 2021 08:48:40 -0400, a ecrit: > > > We're only flushing 2 transients, but there are 3 handles. Use <= to also > > > flush the third handle. > > > > > > The number of transient handles/keys is hardware dependent, so this > > > should query for the limit. And assignment of handles is assumed to be > > > sequential from the minimum. That may not be guaranteed, but seems okay > > > with my tpm2. > > > > > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> > > > > Maybe explicit in the log that TRANSIENT_LAST is actually inclusive? > > In the commit message? Sounds good to me. Yes, please. Samuel
diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c index d9fefa9be6..e0dbcac3ad 100644 --- a/stubdom/vtpmmgr/init.c +++ b/stubdom/vtpmmgr/init.c @@ -656,7 +656,7 @@ static TPM_RC flush_tpm2(void) { int i; - for (i = TRANSIENT_FIRST; i < TRANSIENT_LAST; i++) + for (i = TRANSIENT_FIRST; i <= TRANSIENT_LAST; i++) TPM2_FlushContext(i); return TPM_SUCCESS;
We're only flushing 2 transients, but there are 3 handles. Use <= to also flush the third handle. The number of transient handles/keys is hardware dependent, so this should query for the limit. And assignment of handles is assumed to be sequential from the minimum. That may not be guaranteed, but seems okay with my tpm2. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- stubdom/vtpmmgr/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)