| Message ID | 20210505192007.GA12080@pallavi (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipv6: netfilter.c: fix missing line after declaration | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 10 of 10 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hi Pallavi, On Thu, May 06, 2021 at 12:50:07AM +0530, Pallavi Prabhu wrote: > Fixed a missing line after a declaration for proper coding style. I'd probably suggest to use Coccinelle or similar to make a Netfilter tree wide patch to add line after a declaration. Probably there are more spots in the Netfilter codebase that can benefit from this cleanup. > Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com> > --- > net/ipv6/netfilter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c > index ab9a279dd6d4..7b1671f48593 100644 > --- a/net/ipv6/netfilter.c > +++ b/net/ipv6/netfilter.c > @@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb, > > if (entry->state.hook == NF_INET_LOCAL_OUT) { > const struct ipv6hdr *iph = ipv6_hdr(skb); > + > if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) || > !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) || > skb->mark != rt_info->mark) > -- > 2.25.1 >
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c index ab9a279dd6d4..7b1671f48593 100644 --- a/net/ipv6/netfilter.c +++ b/net/ipv6/netfilter.c @@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb, if (entry->state.hook == NF_INET_LOCAL_OUT) { const struct ipv6hdr *iph = ipv6_hdr(skb); + if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) || !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) || skb->mark != rt_info->mark)
Fixed a missing line after a declaration for proper coding style. Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com> --- net/ipv6/netfilter.c | 1 + 1 file changed, 1 insertion(+)