[v3,0/6] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC

Message

WANG Xuerui May 6, 2021, 1:04 a.m. UTC

It has been a while since v1 of this series was sent (2020-09);
apparently, I did not have enough time or resource figuring out the exact
difference between rtc-ls1x and rtc-ls2x to see if the two can in fact be
merged, even today. Sorry for the long delay!

According to the manuals, though, the initialization sequence and
bitfield descriptions look certainly different, so I'm a bit wary about
just going ahead and merging these. Per Tiezhu's suggestion in the
previous thread, I'm just re-submitting this series with tags collected
and Huacai's e-mail address updated. If anyone (probably Loongson guys?)
could provide more information regarding the possible merger of rtc-ls1x
and rtc-ls2x, that would be great.

This patch series adds support for the RTC module found on various
Loongson systems with the Loongson-2K SoC or the LS7A bridge chip.
The driver is rewritten from an out-of-tree version to meet mainline
standards. I write kernel code as a hobby, though, so there might still
be overlooked issues. Any suggestions are welcome.

Note that, the Loongson-2K platform was upstreamed after v1 of this
series, so v2 additionally contains enablement for it. I'm unable to
test with my 2K board now, however, so Loongson guys, please test this
series again on your collection of LS7A and 2K systems, thanks!

This patch is based on next-20210505, since we're in the middle of merge
window. Should apply cleanly after the merge window closes, though.

v3:
- Fixed compile error not discovered after rebase (blame sleep
  deprivation)
- Tested on Loongson-3A4000 (still need testing on Loongson-2K)

v2:
- Rebased on top of latest linux-next
- Updated Huacai's e-mail address to the kernel.org one
- Added collected tags
- Added adaptation for newly upstreamed Loongson-2K platforms

WANG Xuerui (6):
  rtc: ls2x: Add support for the Loongson-2K/LS7A RTC
  dt-bindings: rtc: Add bindings for LS2X RTC
  MIPS: Loongson64: DTS: Add RTC support to LS7A
  MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig
  MIPS: Loongson64: DTS: Add RTC support to Loongson-2K
  MIPS: Loongson: Enable LS2X RTC in loongson2k_defconfig

 .../devicetree/bindings/rtc/trivial-rtc.yaml  |   2 +
 .../boot/dts/loongson/loongson64-2k1000.dtsi  |   5 +
 arch/mips/boot/dts/loongson/ls7a-pch.dtsi     |   5 +
 arch/mips/configs/loongson2k_defconfig        |   1 +
 arch/mips/configs/loongson3_defconfig         |   1 +
 drivers/rtc/Kconfig                           |  11 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-ls2x.c                        | 225 ++++++++++++++++++
 8 files changed, 251 insertions(+)
 create mode 100644 drivers/rtc/rtc-ls2x.c


base-commit: 29955e0289b3255c5f609a7564a0f0bb4ae35c7a

Comments

Jiaxun Yang May 7, 2021, 2:42 a.m. UTC | #1

On Thu, May 6, 2021, at 9:04 AM, WANG Xuerui wrote:
> It has been a while since v1 of this series was sent (2020-09);
> apparently, I did not have enough time or resource figuring out the exact
> difference between rtc-ls1x and rtc-ls2x to see if the two can in fact be
> merged, even today. Sorry for the long delay!
> 
> According to the manuals, though, the initialization sequence and
> bitfield descriptions look certainly different, so I'm a bit wary about
> just going ahead and merging these. Per Tiezhu's suggestion in the
> previous thread, I'm just re-submitting this series with tags collected
> and Huacai's e-mail address updated. If anyone (probably Loongson guys?)
> could provide more information regarding the possible merger of rtc-ls1x
> and rtc-ls2x, that would be great.
> 
> This patch series adds support for the RTC module found on various
> Loongson systems with the Loongson-2K SoC or the LS7A bridge chip.
> The driver is rewritten from an out-of-tree version to meet mainline
> standards. I write kernel code as a hobby, though, so there might still
> be overlooked issues. Any suggestions are welcome.
> 
> Note that, the Loongson-2K platform was upstreamed after v1 of this
> series, so v2 additionally contains enablement for it. I'm unable to
> test with my 2K board now, however, so Loongson guys, please test this
> series again on your collection of LS7A and 2K systems, thanks!
> 
> This patch is based on next-20210505, since we're in the middle of merge
> window. Should apply cleanly after the merge window closes, though.

For whole series,
Tested-by: Jiaxun Yang <[e-mail]> # loongson2k


> 
> v3:
> - Fixed compile error not discovered after rebase (blame sleep
>   deprivation)
> - Tested on Loongson-3A4000 (still need testing on Loongson-2K)
> 
> v2:
> - Rebased on top of latest linux-next
> - Updated Huacai's e-mail address to the kernel.org one
> - Added collected tags
> - Added adaptation for newly upstreamed Loongson-2K platforms
> 
> WANG Xuerui (6):
>   rtc: ls2x: Add support for the Loongson-2K/LS7A RTC
>   dt-bindings: rtc: Add bindings for LS2X RTC
>   MIPS: Loongson64: DTS: Add RTC support to LS7A
>   MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig
>   MIPS: Loongson64: DTS: Add RTC support to Loongson-2K
>   MIPS: Loongson: Enable LS2X RTC in loongson2k_defconfig
> 
>  .../devicetree/bindings/rtc/trivial-rtc.yaml  |   2 +
>  .../boot/dts/loongson/loongson64-2k1000.dtsi  |   5 +
>  arch/mips/boot/dts/loongson/ls7a-pch.dtsi     |   5 +
>  arch/mips/configs/loongson2k_defconfig        |   1 +
>  arch/mips/configs/loongson3_defconfig         |   1 +
>  drivers/rtc/Kconfig                           |  11 +
>  drivers/rtc/Makefile                          |   1 +
>  drivers/rtc/rtc-ls2x.c                        | 225 ++++++++++++++++++
>  8 files changed, 251 insertions(+)
>  create mode 100644 drivers/rtc/rtc-ls2x.c
> 
> 
> base-commit: 29955e0289b3255c5f609a7564a0f0bb4ae35c7a
> -- 
> 2.30.1
> 
>