mbox series

[v2,0/2] VDM management improvement and some bug fixes

Message ID 20210506171026.1736828-1-kyletso@google.com (mailing list archive)
Headers show
Series VDM management improvement and some bug fixes | expand

Message

Kyle Tso May 6, 2021, 5:10 p.m. UTC
usb: typec: tcpm: Send DISCOVER_IDENTITY from dedicated work
- nothing changed since v1
- Hi, Greg, do I need to add "Reviewed-by:" and "Acked-by:" ?

usb: typec: tcpm: Fix wrong handling for Not_Supported in VDM AMS
- I stacked these two patches because they are somewhat relevant.
- This patch solved 3 bugs
  1. Not_Supported should be acceptable in VDM AMS. Previous design will
     send Soft_Reset after receiving Not_Supported
  2. vdm_sm_running flag should be cleared in some VDM states
  3. If port partner responds Busy, the VDM AMS should finish.

Kyle Tso (2):
  usb: typec: tcpm: Send DISCOVER_IDENTITY from dedicated work
  usb: typec: tcpm: Fix wrong handling for Not_Supported in VDM AMS

 drivers/usb/typec/tcpm/tcpm.c | 99 ++++++++++++++++++++++++++++++-----
 1 file changed, 87 insertions(+), 12 deletions(-)

Comments

Greg Kroah-Hartman May 7, 2021, 6:05 a.m. UTC | #1
On Fri, May 07, 2021 at 01:10:24AM +0800, Kyle Tso wrote:
> usb: typec: tcpm: Send DISCOVER_IDENTITY from dedicated work
> - nothing changed since v1
> - Hi, Greg, do I need to add "Reviewed-by:" and "Acked-by:" ?

If there were reviewed-by and acked-by for the original change, then
yes, you should, otherwise my tools lost them with this new submission.

Can you do a v3?

thanks,

greg k-h