Message ID | 20210506135923.161427-8-jandryuk@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | vtpmmgr: Some fixes - still incomplete | expand |
On 5/6/21 9:59 AM, Jason Andryuk wrote: > We're only flushing 2 transients, but there are 3 handles. Use <= to also > flush the third handle since TRANSIENT_LAST is inclusive > > The number of transient handles/keys is hardware dependent, so this > should query for the limit. And assignment of handles is assumed to be > sequential from the minimum. That may not be guaranteed, but seems okay > with my tpm2. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> > Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> > --- > v2 add "since TRANSIENT_LAST is inclusive" to commit message. > --- Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com> > stubdom/vtpmmgr/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c > index 56b4be85b3..4ae34a4fcb 100644 > --- a/stubdom/vtpmmgr/init.c > +++ b/stubdom/vtpmmgr/init.c > @@ -656,7 +656,7 @@ static TPM_RC flush_tpm2(void) > { > int i; > > - for (i = TRANSIENT_FIRST; i < TRANSIENT_LAST; i++) > + for (i = TRANSIENT_FIRST; i <= TRANSIENT_LAST; i++) > TPM2_FlushContext(i); > > return TPM_SUCCESS; >
diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c index 56b4be85b3..4ae34a4fcb 100644 --- a/stubdom/vtpmmgr/init.c +++ b/stubdom/vtpmmgr/init.c @@ -656,7 +656,7 @@ static TPM_RC flush_tpm2(void) { int i; - for (i = TRANSIENT_FIRST; i < TRANSIENT_LAST; i++) + for (i = TRANSIENT_FIRST; i <= TRANSIENT_LAST; i++) TPM2_FlushContext(i); return TPM_SUCCESS;