| Message ID | 20210505162415.531876-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm + usb-type-c: Add support for out-of-band hotplug notification (v3) | expand |
Hi, On 5/5/21 9:14 PM, Patchwork wrote: > *Patch Details* > *Series:* drm + usb-type-c: Add support for out-of-band hotplug notification (rev3) > *URL:* https://patchwork.freedesktop.org/series/89604/ <https://patchwork.freedesktop.org/series/89604/> > *State:* failure > *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/index.html <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/index.html> > > > CI Bug Log - changes from CI_DRM_10049_full -> Patchwork_20068_full > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_20068_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_20068_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > Possible new issues > > Here are the unknown changes that may have been introduced in Patchwork_20068_full: > > > IGT changes > > > Possible regressions > > * igt@gem_exec_schedule@pi-ringfull@vecs0: > o shard-skl: PASS <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10049/shard-skl4/igt@gem_exec_schedule@pi-ringfull@vecs0.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/shard-skl2/igt@gem_exec_schedule@pi-ringfull@vecs0.html> I believe that this is a false-positive as this series does not touch any related code (it only touches modesetting code). > > > Piglit changes > > > Possible regressions > > * shaders@glsl-fs-texturecube-2 (NEW): > o pig-skl-6260u: NOTRUN -> INCOMPLETE <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/pig-skl-6260u/shaders@glsl-fs-texturecube-2.html> +4 similar issues Idem. Regards, Hans
Hi, On 5/6/21 5:31 PM, Patchwork wrote: > *Patch Details* > *Series:* drm + usb-type-c: Add support for out-of-band hotplug notification (rev3) > *URL:* https://patchwork.freedesktop.org/series/89604/ <https://patchwork.freedesktop.org/series/89604/> > *State:* failure > *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/index.html <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/index.html> > > > CI Bug Log - changes from CI_DRM_10049_full -> Patchwork_20068_full > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_20068_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_20068_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > Possible new issues > > Here are the unknown changes that may have been introduced in Patchwork_20068_full: > > > Piglit changes > > > Possible regressions > > * shaders@glsl-fs-texturecube-2 (NEW): > o pig-skl-6260u: NOTRUN -> INCOMPLETE <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20068/pig-skl-6260u/shaders@glsl-fs-texturecube-2.html> +4 similar issues This seems to be another false-positive as mentioned already this series does not touch any 3d rendering related code (it only touches modesetting code). Regards, Hans
On Wed, May 05, 2021 at 06:24:07PM +0200, Hans de Goede wrote: > Hi All, > > Here is v3 of my patchset making DP over Type-C work on devices where the > Type-C controller does not drive the HPD pin on the GPU, but instead > we need to forward HPD events from the Type-C controller to the DRM driver. These look good to me. I can also test these next week if needed. I'll give my Tested-by tag after that if these haven't been taken by anybody by that. thanks,
On Tue, May 11, 2021 at 10:05:26AM +0300, Heikki Krogerus wrote: > On Wed, May 05, 2021 at 06:24:07PM +0200, Hans de Goede wrote: > > Hi All, > > > > Here is v3 of my patchset making DP over Type-C work on devices where the > > Type-C controller does not drive the HPD pin on the GPU, but instead > > we need to forward HPD events from the Type-C controller to the DRM driver. > > These look good to me. I can also test these next week if needed. I'll > give my Tested-by tag after that if these haven't been taken by > anybody by that. It's almost weird to see console output from the Type-C connector on my good old GPD printed to an actual display :-) At least in my tests, the DP alt mode driver now calls drm_connector_oob_hotplug_event() only when it should. This is pretty cool! FWIW: Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> thanks,
Hi All, Here is v3 of my patchset making DP over Type-C work on devices where the Type-C controller does not drive the HPD pin on the GPU, but instead we need to forward HPD events from the Type-C controller to the DRM driver. Changes in v3: - Base on top of latest drm-tip, which should fix the CI being unable to apply (and thus to test) the patches - Make intel_acpi_assign_connector_fwnodes() take a ref on the fwnode it stores in connector->fwnode and have drm_connector_cleanup() put this reference - Drop data argument from drm_connector_oob_hotplug_event() - Make the Type-C DP altmode code only call drm_connector_oob_hotplug_event() when the HPD bit in the status vdo changes - Drop the platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference patch, this will be merged independently through the pdx86 tree Changes in v2: - Replace the bogus "drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector" patch with: "drm/connector: Give connector sysfs devices there own device_type" the new patch is a dep for patch 2/9 see the patches - Stop using a class-dev-iter, instead at a global connector list to drm_connector.c and use that to find the connector by the fwnode, similar to how we already do this in drm_panel.c and drm_bridge.c - Make drm_connector_oob_hotplug_event() take a fwnode pointer as argument, rather then a drm_connector pointer and let it do the lookup itself. This allows making drm_connector_find_by_fwnode() a drm-internal function and avoids code outside the drm subsystem potentially holding on the a drm_connector reference for a longer period. This series not only touches drm subsys files but it also touches drivers/usb/typec/altmodes/typec_displayport.c, that file usually does not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regards, Hans Hans de Goede (7): drm/connector: Give connector sysfs devices there own device_type drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2) drm/connector: Add drm_connector_find_by_fwnode() function (v2) drm/connector: Add support for out-of-band hotplug notification (v3) drm/i915/dp: Add support for out-of-bound hotplug events usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic usb: typec: altmodes/displayport: Notify drm subsys of hotplug events Heikki Krogerus (1): drm/i915: Associate ACPI connector nodes with connector entries (v2) drivers/gpu/drm/drm_connector.c | 79 ++++++++++++++++++ drivers/gpu/drm/drm_crtc_internal.h | 1 + drivers/gpu/drm/drm_sysfs.c | 87 +++++++++++++++++--- drivers/gpu/drm/i915/display/intel_acpi.c | 46 +++++++++++ drivers/gpu/drm/i915/display/intel_acpi.h | 3 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 12 +++ drivers/usb/typec/altmodes/Kconfig | 1 + drivers/usb/typec/altmodes/displayport.c | 58 ++++++++----- include/drm/drm_connector.h | 25 ++++++ 10 files changed, 278 insertions(+), 35 deletions(-)