| Message ID | 20210508031506.53687-1-cuibixuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] EDAC: ti: Add missing MODULE_DEVICE_TABLE | expand |
On Sat, May 08, 2021 at 11:15:06AM +0800, Bixuan Cui wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless. Also, do $ git grep 'This patch' Documentation/process for more details. > correct modalias for automatic loading of this driver when it is built > as an external module. "external" or simply a module?
On 2021/5/11 19:31, Borislav Petkov wrote: > On Sat, May 08, 2021 at 11:15:06AM +0800, Bixuan Cui wrote: >> This patch adds missing MODULE_DEVICE_TABLE definition which generates > > Avoid having "This patch" or "This commit" in the commit message. It is > tautologically useless. > > Also, do > > $ git grep 'This patch' Documentation/process > > for more details. > >> correct modalias for automatic loading of this driver when it is built >> as an external module. > > "external" or simply a module? I will modify the commit message, thanks. Bixuan Cui >
diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index e7eae20f83d1..169f96e51c29 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = { { .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 }, {}, }; +MODULE_DEVICE_TABLE(of, ti_edac_of_match); static int _emif_get_id(struct device_node *node) {
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> --- drivers/edac/ti_edac.c | 1 + 1 file changed, 1 insertion(+)