diff mbox series

[net-next] net: mdio: Add missing MODULE_DEVICE_TABLE

Message ID 1620790204-15658-1-git-send-email-zou_wei@huawei.com (mailing list archive)
State New, archived
Headers show
Series [net-next] net: mdio: Add missing MODULE_DEVICE_TABLE | expand

Commit Message

Zou Wei May 12, 2021, 3:30 a.m. UTC
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/net/mdio/mdio-aspeed.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joel Stanley May 12, 2021, 6:34 a.m. UTC | #1
On Wed, 12 May 2021 at 03:13, Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Acked-by: Joel Stanley <joel@jms.id.au>

Thanks for the patch.
Andrew Lunn May 12, 2021, 12:42 p.m. UTC | #2
On Wed, May 12, 2021 at 11:30:04AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Please make the subject line more specific. There are a number of MDIO
bus drivers in the kernel. Adding "aspeed:" would make it clear which
one you are changing.

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index cad8205..bb9933f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -141,6 +141,7 @@  static const struct of_device_id aspeed_mdio_of_match[] = {
 	{ .compatible = "aspeed,ast2600-mdio", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
 
 static struct platform_driver aspeed_mdio_driver = {
 	.driver = {