| Message ID | 20210511120107.5781-1-thunder.leizhen@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe() | expand |
Hi Zhen, On 2021-05-11 13:01, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will > be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly > resource > information. > > Therefore, remove the error printing here to simplify code and reduce > the > binary size. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> I'm all grateful for these changes, but can you please organise them in a series and send all the irqchip-related changes at once, instead of one patch every two hours? Thanks, M.
On 2021/5/11 20:08, Marc Zyngier wrote: > Hi Zhen, > > On 2021-05-11 13:01, Zhen Lei wrote: >> When devm_ioremap_resource() fails, a clear enough error message will be >> printed by its subfunction __devm_ioremap_resource(). The error >> information contains the device name, failure cause, and possibly resource >> information. >> >> Therefore, remove the error printing here to simplify code and reduce the >> binary size. >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > > I'm all grateful for these changes, but can you please organise them > in a series and send all the irqchip-related changes at once, instead > of one patch every two hours? OK, I will do it. > > Thanks, > > M.
On 2021/5/11 20:11, Leizhen (ThunderTown) wrote: > > > On 2021/5/11 20:08, Marc Zyngier wrote: >> Hi Zhen, >> >> On 2021-05-11 13:01, Zhen Lei wrote: >>> When devm_ioremap_resource() fails, a clear enough error message will be >>> printed by its subfunction __devm_ioremap_resource(). The error >>> information contains the device name, failure cause, and possibly resource >>> information. >>> >>> Therefore, remove the error printing here to simplify code and reduce the >>> binary size. >>> >>> Reported-by: Hulk Robot <hulkci@huawei.com> >>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> >> I'm all grateful for these changes, but can you please organise them >> in a series and send all the irqchip-related changes at once, instead >> of one patch every two hours? In a hurry yesterday, I misunderstood that they needed to be merged into one patch. Because the rbot reports only one file at a time and there is no file order. I didn't take the time to summarise it at first. > > OK, I will do it. > >> >> Thanks, >> >> M.
On 2021/5/11 20:11, Leizhen (ThunderTown) wrote: > > > On 2021/5/11 20:08, Marc Zyngier wrote: >> Hi Zhen, >> >> On 2021-05-11 13:01, Zhen Lei wrote: >>> When devm_ioremap_resource() fails, a clear enough error message will be >>> printed by its subfunction __devm_ioremap_resource(). The error >>> information contains the device name, failure cause, and possibly resource >>> information. >>> >>> Therefore, remove the error printing here to simplify code and reduce the >>> binary size. >>> >>> Reported-by: Hulk Robot <hulkci@huawei.com> >>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> >> I'm all grateful for these changes, but can you please organise them >> in a series and send all the irqchip-related changes at once, instead >> of one patch every two hours? In a hurry yesterday, I misunderstood that they needed to be merged into one patch. Because the rbot reports only one file at a time and there is no file order. I didn't take the time to summarise it at first. > > OK, I will do it. > >> >> Thanks, >> >> M. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index 91adf771f185973..090bc3f4f7d883d 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -359,10 +359,8 @@ static int mvebu_icu_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); icu->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(icu->base)) { - dev_err(&pdev->dev, "Failed to map icu base address.\n"); + if (IS_ERR(icu->base)) return PTR_ERR(icu->base); - } /* * Legacy bindings: ICU is one node with one MSI parent: force manually
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/irqchip/irq-mvebu-icu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)