[v3,0/8] block: refactor write threshold

Message

Vladimir Sementsov-Ogievskiy May 6, 2021, 9:06 a.m. UTC

Hi all!

v3:
01-04,06,07: add Max's r-b.
01: improve commit msg and comments
03: improve commit msg
05: add more comments and qemu/atomic.h include
08: new, replacement for v2:08,09

Vladimir Sementsov-Ogievskiy (8):
  block/write-threshold: don't use write notifiers
  block: drop write notifiers
  test-write-threshold: rewrite test_threshold_(not_)trigger tests
  block/write-threshold: drop extra APIs
  block/write-threshold: don't use aio context lock
  test-write-threshold: drop extra tests
  test-write-threshold: drop extra TestStruct structure
  write-threshold: deal with includes

 include/block/block_int.h         |  19 ++---
 include/block/write-threshold.h   |  31 +++------
 block.c                           |   1 -
 block/io.c                        |  11 +--
 block/write-threshold.c           | 111 +++++++-----------------------
 tests/unit/test-write-threshold.c |  90 ++----------------------
 6 files changed, 52 insertions(+), 211 deletions(-)

Comments

Stefan Hajnoczi May 12, 2021, 4:03 p.m. UTC | #1

On Thu, May 06, 2021 at 12:06:13PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> v3:
> 01-04,06,07: add Max's r-b.
> 01: improve commit msg and comments
> 03: improve commit msg
> 05: add more comments and qemu/atomic.h include
> 08: new, replacement for v2:08,09
> 
> Vladimir Sementsov-Ogievskiy (8):
>   block/write-threshold: don't use write notifiers
>   block: drop write notifiers
>   test-write-threshold: rewrite test_threshold_(not_)trigger tests
>   block/write-threshold: drop extra APIs
>   block/write-threshold: don't use aio context lock
>   test-write-threshold: drop extra tests
>   test-write-threshold: drop extra TestStruct structure
>   write-threshold: deal with includes
> 
>  include/block/block_int.h         |  19 ++---
>  include/block/write-threshold.h   |  31 +++------
>  block.c                           |   1 -
>  block/io.c                        |  11 +--
>  block/write-threshold.c           | 111 +++++++-----------------------
>  tests/unit/test-write-threshold.c |  90 ++----------------------
>  6 files changed, 52 insertions(+), 211 deletions(-)
> 
> -- 
> 2.29.2
> 

Aside from comments:

Reviewed-by: Stefan Hajnoczi <[e-mail]>

Max Reitz May 12, 2021, 5:31 p.m. UTC | #2

On 06.05.21 11:06, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> v3:
> 01-04,06,07: add Max's r-b.
> 01: improve commit msg and comments
> 03: improve commit msg
> 05: add more comments and qemu/atomic.h include
> 08: new, replacement for v2:08,09
> 
> Vladimir Sementsov-Ogievskiy (8):
>    block/write-threshold: don't use write notifiers
>    block: drop write notifiers
>    test-write-threshold: rewrite test_threshold_(not_)trigger tests
>    block/write-threshold: drop extra APIs
>    block/write-threshold: don't use aio context lock
>    test-write-threshold: drop extra tests
>    test-write-threshold: drop extra TestStruct structure
>    write-threshold: deal with includes
> 
>   include/block/block_int.h         |  19 ++---
>   include/block/write-threshold.h   |  31 +++------
>   block.c                           |   1 -
>   block/io.c                        |  11 +--
>   block/write-threshold.c           | 111 +++++++-----------------------
>   tests/unit/test-write-threshold.c |  90 ++----------------------
>   6 files changed, 52 insertions(+), 211 deletions(-)

Thanks, I’ve applied all patches but patch 5 to my block branch, with 
the changes Eric has suggested:

https://github.com/XanClic/qemu/commits/block

Max