diff mbox series

[v3,2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

Message ID 20210513041446.3082-3-chris.chiu@canonical.com (mailing list archive)
State Superseded
Headers show
Series USB: propose a generic fix for PORT_SUSPEND set feature timeout | expand

Commit Message

Chris Chiu May 13, 2021, 4:14 a.m. UTC 
From: Chris Chiu <chris.chiu@canonical.com>

This reverts commit ca91fd8c7643d93bfc18a6fec1a0d3972a46a18a. The
problematic hub should be taken care for each setting PORT_SUSPEND
feature timeout instead of reset-resume all the time.

Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
---
 drivers/usb/core/quirks.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alan Stern May 13, 2021, 2:40 p.m. UTC | #1 
On Thu, May 13, 2021 at 12:14:46PM +0800, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
> 
> This reverts commit ca91fd8c7643d93bfc18a6fec1a0d3972a46a18a. The

Use the proper format for referring to commits: just the first 12 hex 
digits of the commit ID, followed by the commit's name in parentheses 
and quotation marks.  See other patch submissions in the mailing list 
archives for examples.

> problematic hub should be taken care for each setting PORT_SUSPEND
> feature timeout instead of reset-resume all the time.

The last sentence is not grammatical.  It should say something more 
like:

	The previous patch in this series now handles problematic hubs
	by checking the port status when a PORT_SUSPEND timeout occurs,
	so we don't need to use reset-resume all the time.

Alan Stern

> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
>  drivers/usb/core/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 21e7522655ac..6114cf83bb44 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -406,7 +406,6 @@ static const struct usb_device_id usb_quirk_list[] = {
>  
>  	/* Realtek hub in Dell WD19 (Type-C) */
>  	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
> -	{ USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
>  
>  	/* Generic RTL8153 based ethernet adapters */
>  	{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 21e7522655ac..6114cf83bb44 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -406,7 +406,6 @@  static const struct usb_device_id usb_quirk_list[] = {
 
 	/* Realtek hub in Dell WD19 (Type-C) */
 	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
-	{ USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
 
 	/* Generic RTL8153 based ethernet adapters */
 	{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },