| Message ID | 20210513163858.3928976-9-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Various Kconfig fixes | expand |
On Thu, May 13, 2021 at 06:38:56PM +0200, Philippe Mathieu-Daudé wrote: > Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate > RTC with it") added a global dependency on the DS1338 model, instead > of a machine one (via Kconfig). This gives trouble when building > standalone machines not exposing I2C bus: > > The following clauses were found for DS1338 > > CONFIG_DS1338=y > config DS1338 depends on I2C > > Fix by selecting the DS1338 symbol in the single machine requiring > it, the E500. > > Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > Cc: Amit Singh Tomar <amit.tomar@freescale.com> > Cc: Andrew Randrianasulu <randrianasulu@gmail.com> > --- > default-configs/devices/ppc-softmmu.mak | 1 - > hw/ppc/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devices/ppc-softmmu.mak > index c2d41198cde..5a7f99d1e45 100644 > --- a/default-configs/devices/ppc-softmmu.mak > +++ b/default-configs/devices/ppc-softmmu.mak > @@ -1,7 +1,6 @@ > # Default configuration for ppc-softmmu > > # For embedded PPCs: > -CONFIG_DS1338=y > CONFIG_E500=y > CONFIG_PPC405=y > CONFIG_PPC440=y > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index 66e0b15d9ef..2e4c56eb770 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -128,6 +128,7 @@ config E500 > select SERIAL > select MPC_I2C > select FDT_PPC > + select DS1338 > > config VIRTEX > bool
On Fri, May 14, 2021 at 1:02 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate > RTC with it") added a global dependency on the DS1338 model, instead > of a machine one (via Kconfig). This gives trouble when building > standalone machines not exposing I2C bus: > > The following clauses were found for DS1338 > > CONFIG_DS1338=y > config DS1338 depends on I2C > > Fix by selecting the DS1338 symbol in the single machine requiring > it, the E500. > > Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Cc: Amit Singh Tomar <amit.tomar@freescale.com> > Cc: Andrew Randrianasulu <randrianasulu@gmail.com> > --- > default-configs/devices/ppc-softmmu.mak | 1 - > hw/ppc/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devices/ppc-softmmu.mak index c2d41198cde..5a7f99d1e45 100644 --- a/default-configs/devices/ppc-softmmu.mak +++ b/default-configs/devices/ppc-softmmu.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu # For embedded PPCs: -CONFIG_DS1338=y CONFIG_E500=y CONFIG_PPC405=y CONFIG_PPC440=y diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 66e0b15d9ef..2e4c56eb770 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -128,6 +128,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 config VIRTEX bool
Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=y config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Amit Singh Tomar <amit.tomar@freescale.com> Cc: Andrew Randrianasulu <randrianasulu@gmail.com> --- default-configs/devices/ppc-softmmu.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)