| Message ID | 20210514095339.12979-4-ionela.voinescu@arm.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arch_topology, ACPI: populate cpu capacity from CPPC | expand |
On Fri, May 14, 2021 at 10:53:39AM +0100, Ionela Voinescu wrote: > Now that the arch topology driver provides a method of setting CPU > capacity values based on information on highest performance from CPPC, > use this functionality on arm64 platforms. > > Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
On 14/05/2021 11:53, Ionela Voinescu wrote: [...] > +#ifdef CONFIG_ACPI_CPPC_LIB > +#define arch_init_invariance_cppc init_cpu_capacity_cppc > +#endif The prefix `topology_` was meant to indicate that those functions come from drivers/base/arch_topology.c. You probably refrained from it since topology_init_cpu_capacity_cppc() is a pretty long function name ... Still more consistent though. [...]
On Friday 14 May 2021 at 18:17:00 (+0200), Dietmar Eggemann wrote: > On 14/05/2021 11:53, Ionela Voinescu wrote: > > [...] > > > +#ifdef CONFIG_ACPI_CPPC_LIB > > +#define arch_init_invariance_cppc init_cpu_capacity_cppc > > +#endif > > The prefix `topology_` was meant to indicate that those functions come > from drivers/base/arch_topology.c. You probably refrained from it since > > topology_init_cpu_capacity_cppc() > > is a pretty long function name ... Still more consistent though. > I'll rename it, thanks! Ionela. > [...] >
diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h index ec2db3419c41..c6ae6b55789c 100644 --- a/arch/arm64/include/asm/topology.h +++ b/arch/arm64/include/asm/topology.h @@ -24,6 +24,10 @@ void update_freq_counters_refs(void); #define arch_scale_freq_capacity topology_get_freq_scale #define arch_scale_freq_invariant topology_scale_freq_invariant +#ifdef CONFIG_ACPI_CPPC_LIB +#define arch_init_invariance_cppc init_cpu_capacity_cppc +#endif + /* Replace task scheduler's default cpu-invariant accounting */ #define arch_scale_cpu_capacity topology_get_cpu_scale
Now that the arch topology driver provides a method of setting CPU capacity values based on information on highest performance from CPPC, use this functionality on arm64 platforms. Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> --- arch/arm64/include/asm/topology.h | 4 ++++ 1 file changed, 4 insertions(+)