| Message ID | 3254d58a6dabd03533816388bd6dcb04f8078e6a.1621358167.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | f3d3cf12ada2ec826ac13bd531a3349f17226742 |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-net] mptcp: avoid error message on infinite mapping | expand |
On Tue, 18 May 2021, Paolo Abeni wrote: > Another left-over. Avoid flooding dmesg with useless text, > we already have a MIB for that event. > > Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path") > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > net/mptcp/subflow.c | 1 - > 1 file changed, 1 deletion(-) Thanks for the patch. Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> > > diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c > index 9befe9fe7bca..02b1ff06c741 100644 > --- a/net/mptcp/subflow.c > +++ b/net/mptcp/subflow.c > @@ -951,7 +951,6 @@ static enum mapping_status get_mapping_status(struct sock *ssk, > > data_len = mpext->data_len; > if (data_len == 0) { > - pr_err("Infinite mapping not handled"); > MPTCP_INC_STATS(sock_net(ssk), MPTCP_MIB_INFINITEMAPRX); > return MAPPING_INVALID; > } > -- > 2.26.3 > > > -- Mat Martineau Intel
Hi Paolo, Mat, On 18/05/2021 19:16, Paolo Abeni wrote: > Another left-over. Avoid flooding dmesg with useless text, > we already have a MIB for that event. > > Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path") > Signed-off-by: Paolo Abeni <pabeni@redhat.com> Thank you for the patch and the review! - f3d3cf12ada2: mptcp: avoid error message on infinite mapping - Results: f7c7d5a50852..bffd86183cb5 Builds and tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210520T183513 https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210520T183513 Cheers, Matt
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 9befe9fe7bca..02b1ff06c741 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -951,7 +951,6 @@ static enum mapping_status get_mapping_status(struct sock *ssk, data_len = mpext->data_len; if (data_len == 0) { - pr_err("Infinite mapping not handled"); MPTCP_INC_STATS(sock_net(ssk), MPTCP_MIB_INFINITEMAPRX); return MAPPING_INVALID; }
Another left-over. Avoid flooding dmesg with useless text, we already have a MIB for that event. Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path") Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- net/mptcp/subflow.c | 1 - 1 file changed, 1 deletion(-)