diff mbox series

[BlueZ,v2,1/5] mesh: Fix delivery of PB-ACK to acceptors

Message ID 20210519182150.1680987-2-brian.gix@intel.com (mailing list archive)
State New, archived
Headers show
Series OOB Authentication improvements | expand

Commit Message

Brian Gix May 19, 2021, 6:21 p.m. UTC 
Rwmove unneeded initialization that prevented the Acceptor roll of ever
recognizing a valid PB-ACK.
---
 mesh/pb-adv.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tedd Ho-Jeong An May 19, 2021, 6:30 p.m. UTC | #1 
Hi Brian,

On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> Rwmove unneeded initialization that prevented the Acceptor roll of ever

Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".

> recognizing a valid PB-ACK.
> ---
>  mesh/pb-adv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> index c74dae79f..83f922aa8 100644
> --- a/mesh/pb-adv.c
> +++ b/mesh/pb-adv.c
> @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
>  		first = !session->link_id;
>  		session->link_id = link_id;
>  		session->last_peer_trans_num = 0xFF;
> -		session->local_acked = 0xFF;
>  		session->peer_trans_num = 0x00;
>  		session->local_trans_num = 0x7F;
>  		session->opened = true;

Regards,
Tedd
Brian Gix May 19, 2021, 6:33 p.m. UTC | #2 
On Wed, 2021-05-19 at 11:30 -0700, Tedd Ho-Jeong An wrote:
> Hi Brian,
> 
> On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> > Rwmove unneeded initialization that prevented the Acceptor roll of ever
> 
> Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".

Thanks Tedd -- If no other issues are found, I will fix when it is applied.

> > recognizing a valid PB-ACK.
> > ---
> >  mesh/pb-adv.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> > index c74dae79f..83f922aa8 100644
> > --- a/mesh/pb-adv.c
> > +++ b/mesh/pb-adv.c
> > @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
> >  		first = !session->link_id;
> >  		session->link_id = link_id;
> >  		session->last_peer_trans_num = 0xFF;
> > -		session->local_acked = 0xFF;
> >  		session->peer_trans_num = 0x00;
> >  		session->local_trans_num = 0x7F;
> >  		session->opened = true;
> 
> Regards,
> Tedd
>
bluez.test.bot@gmail.com May 19, 2021, 7:01 p.m. UTC | #3 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=485239

---Test result---

Test Summary:
CheckPatch                    PASS      1.78 seconds
GitLint                       PASS      0.63 seconds
Prep - Setup ELL              PASS      49.25 seconds
Build - Prep                  PASS      0.15 seconds
Build - Configure             PASS      8.62 seconds
Build - Make                  PASS      214.90 seconds
Make Check                    PASS      8.97 seconds
Make Distcheck                PASS      252.99 seconds
Build w/ext ELL - Configure   PASS      8.65 seconds
Build w/ext ELL - Make        PASS      202.95 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
index c74dae79f..83f922aa8 100644
--- a/mesh/pb-adv.c
+++ b/mesh/pb-adv.c
@@ -358,7 +358,6 @@  static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
 		first = !session->link_id;
 		session->link_id = link_id;
 		session->last_peer_trans_num = 0xFF;
-		session->local_acked = 0xFF;
 		session->peer_trans_num = 0x00;
 		session->local_trans_num = 0x7F;
 		session->opened = true;