| Message ID | 1621318822-29332-3-git-send-email-skakit@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add PMIC DT files for sc7280 | expand |
On 18-05-21, 11:50, satya priya wrote: > Add thermal-zones node for SC7280 SoC. > > Signed-off-by: satya priya <skakit@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in RESEND V4: > - No Changes. > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 2cc4785..2a7d488 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1125,4 +1125,7 @@ > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; > }; > + > + thermal_zones: thermal-zones { > + }; Empty node..? what am i missing here...
On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote: > On 18-05-21, 11:50, satya priya wrote: > > Add thermal-zones node for SC7280 SoC. > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > Changes in RESEND V4: > > - No Changes. > > > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > index 2cc4785..2a7d488 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > @@ -1125,4 +1125,7 @@ > > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, > > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; > > }; > > + > > + thermal_zones: thermal-zones { > > + }; > > Empty node..? what am i missing here... The 'thermal-zones' node with the SoC thermal zones is usually created in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings and device tree nodes for TSENS in SC7280' series (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225) is creating it, but the series hasn't landed yet. The node is needed by other patches in this series that add non-SoC thermal zones. Hence either an empty node needs to be added (for now) or this series should 'officially' depend on the TSENS series mentioned above.
On 18/05/2021 19:27, Matthias Kaehlcke wrote: > On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote: >> On 18-05-21, 11:50, satya priya wrote: >>> Add thermal-zones node for SC7280 SoC. >>> >>> Signed-off-by: satya priya <skakit@codeaurora.org> >>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >>> --- >>> Changes in RESEND V4: >>> - No Changes. >>> >>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> index 2cc4785..2a7d488 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> @@ -1125,4 +1125,7 @@ >>> <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, >>> <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; >>> }; >>> + >>> + thermal_zones: thermal-zones { >>> + }; >> >> Empty node..? what am i missing here... > > The 'thermal-zones' node with the SoC thermal zones is usually created > in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings > and device tree nodes for TSENS in SC7280' series > (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225) > is creating it, but the series hasn't landed yet. > > The node is needed by other patches in this series that add non-SoC > thermal zones. Hence either an empty node needs to be added (for now) > or this series should 'officially' depend on the TSENS series mentioned > above. You can reference the TZ node as /thermal-zones/ even from non-SoC includes. See pm8150.dtsi for example.
Hi Matthias, On 2021-05-18 21:57, Matthias Kaehlcke wrote: > On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote: >> On 18-05-21, 11:50, satya priya wrote: >> > Add thermal-zones node for SC7280 SoC. >> > >> > Signed-off-by: satya priya <skakit@codeaurora.org> >> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >> > --- >> > Changes in RESEND V4: >> > - No Changes. >> > >> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > index 2cc4785..2a7d488 100644 >> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > @@ -1125,4 +1125,7 @@ >> > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, >> > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; >> > }; >> > + >> > + thermal_zones: thermal-zones { >> > + }; >> >> Empty node..? what am i missing here... > > The 'thermal-zones' node with the SoC thermal zones is usually created > in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings > and device tree nodes for TSENS in SC7280' series > (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225) > is creating it, but the series hasn't landed yet. > > The node is needed by other patches in this series that add non-SoC > thermal zones. Hence either an empty node needs to be added (for now) > or this series should 'officially' depend on the TSENS series mentioned > above. I will add the dependency in cover letter and drop this patch. Thanks, Satya Priya
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 2cc4785..2a7d488 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -1125,4 +1125,7 @@ <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; }; + + thermal_zones: thermal-zones { + }; };