| Message ID | 20210514122051.266169-3-ikjn@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support cbas tablet mode switch to mt8183 | expand |
Hi Ikjoon, Thank you for the patch. On 14/5/21 14:20, Ikjoon Jang wrote: > Add a 'cbas' device node for supporting tablet mode switch in > kukui devices. > > Kukui platforms with detacheable base have an additional input > device under cros-ec, which reports SW_TABLET_MODE regarding > its base state (e.g. base flipped or detached). > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v7: > - remove a label in cbas node > - fix an erratum in commit message (table --> tablet) > - dt-binding patchess merged altogether with mt8183 dts > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index ff56bcfa3370..1512605a438e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -816,6 +816,10 @@ usbc_extcon: extcon0 { > compatible = "google,extcon-usbc-cros-ec"; > google,usb-port-id = <0>; > }; > + > + cbas { > + compatible = "google,cros-cbas"; > + }; > }; > }; > >
Quoting Ikjoon Jang (2021-05-14 05:20:50) > Add a 'cbas' device node for supporting tablet mode switch in > kukui devices. > > Kukui platforms with detacheable base have an additional input > device under cros-ec, which reports SW_TABLET_MODE regarding > its base state (e.g. base flipped or detached). > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org> > > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Hi Ikjoon, Thank you for the patch. On 14/5/21 14:20, Ikjoon Jang wrote: > Add a 'cbas' device node for supporting tablet mode switch in > kukui devices. > > Kukui platforms with detacheable base have an additional input > device under cros-ec, which reports SW_TABLET_MODE regarding > its base state (e.g. base flipped or detached). > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v7: > - remove a label in cbas node > - fix an erratum in commit message (table --> tablet) > - dt-binding patchess merged altogether with mt8183 dts > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index ff56bcfa3370..1512605a438e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -816,6 +816,10 @@ usbc_extcon: extcon0 { > compatible = "google,extcon-usbc-cros-ec"; > google,usb-port-id = <0>; > }; > + > + cbas { > + compatible = "google,cros-cbas"; > + }; > }; > }; > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index ff56bcfa3370..1512605a438e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -816,6 +816,10 @@ usbc_extcon: extcon0 { compatible = "google,extcon-usbc-cros-ec"; google,usb-port-id = <0>; }; + + cbas { + compatible = "google,cros-cbas"; + }; }; };
Add a 'cbas' device node for supporting tablet mode switch in kukui devices. Kukui platforms with detacheable base have an additional input device under cros-ec, which reports SW_TABLET_MODE regarding its base state (e.g. base flipped or detached). Signed-off-by: Ikjoon Jang <ikjn@chromium.org> --- Changes in v7: - remove a label in cbas node - fix an erratum in commit message (table --> tablet) - dt-binding patchess merged altogether with mt8183 dts arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++ 1 file changed, 4 insertions(+)