| Message ID | YKaIKXOcDb0nXguP@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: hantro: test the correct variable in probe() | expand |
Hi Dan, Thank you for the patch. On 2021/05/20, Dan Carpenter wrote: > This should be testing "vpu->clocks[0].clk" instead of "vpu->clocks". > > Fixes: eb4cacdfb998 ("media: hantro: add fallback handling for single irq/clk") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> -Emil
diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c index 85dcb0882afc..8ac476be1682 100644 --- a/drivers/staging/media/hantro/hantro_drv.c +++ b/drivers/staging/media/hantro/hantro_drv.c @@ -780,8 +780,8 @@ static int hantro_probe(struct platform_device *pdev) * actual name in the DT bindings. */ vpu->clocks[0].clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(vpu->clocks)) - return PTR_ERR(vpu->clocks); + if (IS_ERR(vpu->clocks[0].clk)) + return PTR_ERR(vpu->clocks[0].clk); } num_bases = vpu->variant->num_regs ?: 1;
This should be testing "vpu->clocks[0].clk" instead of "vpu->clocks". Fixes: eb4cacdfb998 ("media: hantro: add fallback handling for single irq/clk") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/staging/media/hantro/hantro_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)