| Message ID | 20210514192218.13022-5-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add new Renesas RZ/G2L SoC and Renesas RZ/G2L SMARC EVK support | expand |
Hi Prabhakar, On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add ARCH_R9A07G044{L,LC} as a configuration symbol for the new Renesas > RZ/G2{L,LC} SoC's. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -279,6 +279,16 @@ config ARCH_R8A774B1 > help > This enables support for the Renesas RZ/G2N SoC. > > +config ARCH_R9A07G044L > + bool "ARM64 Platform support for RZ/G2L SoC" Please drop the "SoC", for consistency with other entries. > + help > + This enables support for the Renesas RZ/G2L SoC. > + > +config ARCH_R9A07G044LC > + bool "ARM64 Platform support for RZ/G2LC SoC" Likewise. > + help > + This enables support for the Renesas RZ/G2LC SoC. > + > endif # ARM64 Given LSI DEVID is the same, do we need both, or can we do with a single ARCH_R9A07G044? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Fri, May 21, 2021 at 2:25 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add ARCH_R9A07G044{L,LC} as a configuration symbol for the new Renesas > > RZ/G2{L,LC} SoC's. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/drivers/soc/renesas/Kconfig > > +++ b/drivers/soc/renesas/Kconfig > > @@ -279,6 +279,16 @@ config ARCH_R8A774B1 > > help > > This enables support for the Renesas RZ/G2N SoC. > > > > +config ARCH_R9A07G044L > > + bool "ARM64 Platform support for RZ/G2L SoC" > > Please drop the "SoC", for consistency with other entries. > Oops will do that. > > + help > > + This enables support for the Renesas RZ/G2L SoC. > > + > > +config ARCH_R9A07G044LC > > + bool "ARM64 Platform support for RZ/G2LC SoC" > > Likewise. > will do. > > + help > > + This enables support for the Renesas RZ/G2LC SoC. > > + > > endif # ARM64 > > Given LSI DEVID is the same, do we need both, or can we do with a > single ARCH_R9A07G044? > The reason behind adding separate configs was in case if we wanted to just build an image for RZ/G2L and not RZ/G2LC this would increase image size and also build unneeded dtb's. Cheers, Prabhakar > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Prabhakar, On Fri, May 21, 2021 at 7:21 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Fri, May 21, 2021 at 2:25 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > Add ARCH_R9A07G044{L,LC} as a configuration symbol for the new Renesas > > > RZ/G2{L,LC} SoC's. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- a/drivers/soc/renesas/Kconfig > > > +++ b/drivers/soc/renesas/Kconfig > > > @@ -279,6 +279,16 @@ config ARCH_R8A774B1 > > > help > > > This enables support for the Renesas RZ/G2N SoC. > > > > > > +config ARCH_R9A07G044L > > > + bool "ARM64 Platform support for RZ/G2L SoC" > > > > Please drop the "SoC", for consistency with other entries. > > > Oops will do that. > > > > + help > > > + This enables support for the Renesas RZ/G2L SoC. > > > + > > > +config ARCH_R9A07G044LC > > > + bool "ARM64 Platform support for RZ/G2LC SoC" > > > > Likewise. > > > will do. > > > > + help > > > + This enables support for the Renesas RZ/G2LC SoC. > > > + > > > endif # ARM64 > > > > Given LSI DEVID is the same, do we need both, or can we do with a > > single ARCH_R9A07G044? > > > The reason behind adding separate configs was in case if we wanted to > just build an image for RZ/G2L and not RZ/G2LC this would increase > image size and also build unneeded dtb's. How would it increase image size? I understand clock and pin control are the same blocks. Gr{oetje,eeting}s, Geert
diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index b70bbc38efc6..61968bbd2ed2 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -279,6 +279,16 @@ config ARCH_R8A774B1 help This enables support for the Renesas RZ/G2N SoC. +config ARCH_R9A07G044L + bool "ARM64 Platform support for RZ/G2L SoC" + help + This enables support for the Renesas RZ/G2L SoC. + +config ARCH_R9A07G044LC + bool "ARM64 Platform support for RZ/G2LC SoC" + help + This enables support for the Renesas RZ/G2LC SoC. + endif # ARM64 config RST_RCAR
Add ARCH_R9A07G044{L,LC} as a configuration symbol for the new Renesas RZ/G2{L,LC} SoC's. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/soc/renesas/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)