| Message ID | 20210522031911.129361-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] staging: media: tegra-vde: add missing error return code in tegra_vde_probe() | expand |
22.05.2021 06:19, Yang Yingliang пишет: > Add missing return error code when pm_runtime_resume_and_get() failed. > > Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/staging/media/tegra-vde/vde.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c > index e025b69776f2..ed4c1250b303 100644 > --- a/drivers/staging/media/tegra-vde/vde.c > +++ b/drivers/staging/media/tegra-vde/vde.c > @@ -1071,7 +1071,8 @@ static int tegra_vde_probe(struct platform_device *pdev) > * power-cycle it in order to put hardware into a predictable lower > * power state. > */ > - if (pm_runtime_resume_and_get(dev) < 0) > + err = pm_runtime_resume_and_get(dev); > + if (err) > goto err_pm_runtime; > > pm_runtime_put(dev); > Hello Yang, Thank you for the patch. The problem was already reported by Dan Carpenter to the original patch, apparently Mauro missed it. Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c index e025b69776f2..ed4c1250b303 100644 --- a/drivers/staging/media/tegra-vde/vde.c +++ b/drivers/staging/media/tegra-vde/vde.c @@ -1071,7 +1071,8 @@ static int tegra_vde_probe(struct platform_device *pdev) * power-cycle it in order to put hardware into a predictable lower * power state. */ - if (pm_runtime_resume_and_get(dev) < 0) + err = pm_runtime_resume_and_get(dev); + if (err) goto err_pm_runtime; pm_runtime_put(dev);
Add missing return error code when pm_runtime_resume_and_get() failed. Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/staging/media/tegra-vde/vde.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)