diff mbox series

bpftool: Add sock_release help info for cgroup attach command

Message ID 20210524071548.115138-1-liujian56@huawei.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series bpftool: Add sock_release help info for cgroup attach command | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Liu Jian May 24, 2021, 7:15 a.m. UTC
Fixes: db94cc0b4805 ("bpftool: Add support for BPF_CGROUP_INET_SOCK_RELEASE")
Signed-off-by: Liu Jian <liujian56@huawei.com>
---
 tools/bpf/bpftool/cgroup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Greg KH May 24, 2021, 7:21 a.m. UTC | #1
On Mon, May 24, 2021 at 03:15:48PM +0800, Liu Jian wrote:
> Fixes: db94cc0b4805 ("bpftool: Add support for BPF_CGROUP_INET_SOCK_RELEASE")
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> ---
>  tools/bpf/bpftool/cgroup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I know I do not take patches without any changelog text, maybe other
maintainers are more leniant...
Liu Jian May 24, 2021, 7:34 a.m. UTC | #2
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, May 24, 2021 3:21 PM
> To: liujian (CE) <liujian56@huawei.com>
> Cc: ast@kernel.org; daniel@iogearbox.net; andrii@kernel.org; kafai@fb.com;
> songliubraving@fb.com; yhs@fb.com; john.fastabend@gmail.com;
> kpsingh@kernel.org; quentin@isovalent.com; sdf@google.com;
> netdev@vger.kernel.org; bpf@vger.kernel.org
> Subject: Re: [PATCH] bpftool: Add sock_release help info for cgroup attach
> command
> 
> On Mon, May 24, 2021 at 03:15:48PM +0800, Liu Jian wrote:
> > Fixes: db94cc0b4805 ("bpftool: Add support for
> > BPF_CGROUP_INET_SOCK_RELEASE")
> > Signed-off-by: Liu Jian <liujian56@huawei.com>
> > ---
> >  tools/bpf/bpftool/cgroup.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I know I do not take patches without any changelog text, maybe other
> maintainers are more leniant...

Sorry, I will send v2 for the bad habits.  Thank you ~
diff mbox series

Patch

diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c
index d901cc1b904a..6e53b1d393f4 100644
--- a/tools/bpf/bpftool/cgroup.c
+++ b/tools/bpf/bpftool/cgroup.c
@@ -28,7 +28,8 @@ 
 	"                        connect6 | getpeername4 | getpeername6 |\n"   \
 	"                        getsockname4 | getsockname6 | sendmsg4 |\n"   \
 	"                        sendmsg6 | recvmsg4 | recvmsg6 |\n"           \
-	"                        sysctl | getsockopt | setsockopt }"
+	"                        sysctl | getsockopt | setsockopt |\n"	       \
+	"                        sock_release }"
 
 static unsigned int query_flags;