| Message ID | 20210524164131.383778-1-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20210524164131.383778-1-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210524164131.383778-1-pbonzini@redhat.com Subject: [PULL 00/28] Misc patches for 2021-05-24 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210520152840.24453-1-peter.maydell@linaro.org -> patchew/20210520152840.24453-1-peter.maydell@linaro.org * [new tag] patchew/20210524164131.383778-1-pbonzini@redhat.com -> patchew/20210524164131.383778-1-pbonzini@redhat.com Switched to a new branch 'test' 0fa080f gitlab-ci: use --meson=git for CFI jobs bbddd33 hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio 3905339 configure: Avoid error messages about missing *-config-*.h files de92a99 doc: Add notes about -mon option mode=control argument. 42b8d6b qemu-config: load modules when instantiating option groups 5219b76 vl: allow not specifying size in -m when using -M memory-backend 72e9baf replication: move include out of root directory ce41cf6 remove qemu-options* from root directory ce87fc2 meson: Set implicit_include_directories to false 9832b50 tests/qtest/fuzz: Fix build failure c0901ba KVM: Dirty ring support 11082db KVM: Disable manual dirty log when dirty ring enabled b01a662 KVM: Add dirty-ring-size property 95a5168 KVM: Cache kvm slot dirty bitmap size e62cfb6 KVM: Simplify dirty log sync in kvm_set_phys_mem c9334d4 KVM: Provide helper to sync dirty bitmap from slot to ramblock 57bbb8d KVM: Provide helper to get kvm dirty log b4bad4a KVM: Create the KVMSlot dirty bitmap on flag changes f3264ce KVM: Use a big lock to replace per-kml slots_lock 2d1e6d4 memory: Introduce log_sync_global() to memory listener 4252ee3 KVM: do not allow setting properties at runtime 373bf6f qtest: add a QOM object for qtest 5d462c5 object: add more commands to preconfig mode d850681 i386/cpu: Expose AVX_VNNI instruction to guest 3827fa7 hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' 0d602e0 configure: simplify assignment to GIT_SUBMODULES 8e551f5 configure: check for submodules if --with-git-submodules=ignore 173e6ca configure: Only clone softfloat-3 repositories if TCG is enabled === OUTPUT BEGIN === 1/28 Checking commit 173e6cae6713 (configure: Only clone softfloat-3 repositories if TCG is enabled) 2/28 Checking commit 8e551f518944 (configure: check for submodules if --with-git-submodules=ignore) 3/28 Checking commit 0d602e0162d6 (configure: simplify assignment to GIT_SUBMODULES) 4/28 Checking commit 3827fa74f840 (hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on') 5/28 Checking commit d850681c4caf (i386/cpu: Expose AVX_VNNI instruction to guest) 6/28 Checking commit 5d462c51f715 (object: add more commands to preconfig mode) 7/28 Checking commit 373bf6f3d4ee (qtest: add a QOM object for qtest) 8/28 Checking commit 4252ee36526c (KVM: do not allow setting properties at runtime) ERROR: line over 90 characters #33: FILE: accel/kvm/kvm-all.c:3115: + error_setg(errp, "Cannot set properties after the accelerator has been initialized"); ERROR: line over 90 characters #45: FILE: accel/kvm/kvm-all.c:3134: + error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 2 errors, 0 warnings, 37 lines checked Patch 8/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/28 Checking commit 2d1e6d4364d0 (memory: Introduce log_sync_global() to memory listener) 10/28 Checking commit f3264ce3e7d1 (KVM: Use a big lock to replace per-kml slots_lock) 11/28 Checking commit b4bad4a990b0 (KVM: Create the KVMSlot dirty bitmap on flag changes) 12/28 Checking commit 57bbb8d7afa0 (KVM: Provide helper to get kvm dirty log) 13/28 Checking commit c9334d40deca (KVM: Provide helper to sync dirty bitmap from slot to ramblock) 14/28 Checking commit e62cfb673d6a (KVM: Simplify dirty log sync in kvm_set_phys_mem) 15/28 Checking commit 95a5168a97dc (KVM: Cache kvm slot dirty bitmap size) 16/28 Checking commit b01a66229a2b (KVM: Add dirty-ring-size property) ERROR: line over 90 characters #59: FILE: accel/kvm/kvm-all.c:3206: + error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 1 errors, 0 warnings, 94 lines checked Patch 16/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/28 Checking commit 11082db128f9 (KVM: Disable manual dirty log when dirty ring enabled) 18/28 Checking commit c0901bac0ef8 (KVM: Dirty ring support) WARNING: line over 80 characters #451: FILE: accel/kvm/kvm-all.c:2466: + "Suggested mininum value is 1024.", strerror(-ret)); total: 0 errors, 1 warnings, 498 lines checked Patch 18/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/28 Checking commit 9832b50ccd68 (tests/qtest/fuzz: Fix build failure) 20/28 Checking commit ce87fc249114 (meson: Set implicit_include_directories to false) 21/28 Checking commit ce41cf677623 (remove qemu-options* from root directory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: rename from qemu-options.h ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: include/qemu/qemu-options.h:33: +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \ + opt_enum, total: 1 errors, 1 warnings, 79 lines checked Patch 21/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/28 Checking commit 72e9baff20b0 (replication: move include out of root directory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: rename from replication.h total: 0 errors, 1 warnings, 48 lines checked Patch 22/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/28 Checking commit 5219b76f7875 (vl: allow not specifying size in -m when using -M memory-backend) 24/28 Checking commit 42b8d6b42859 (qemu-config: load modules when instantiating option groups) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 0 errors, 1 warnings, 61 lines checked Patch 24/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/28 Checking commit de92a997222a (doc: Add notes about -mon option mode=control argument.) ERROR: Author email address is mangled by the mailing list #2: Author: Ali Shirvani via <qemu-devel@nongnu.org> ERROR: trailing whitespace #28: FILE: qemu-options.hx:3802: + Setup monitor on chardev name. ``mode=control`` configures $ ERROR: trailing whitespace #31: FILE: qemu-options.hx:3805: + ``pretty`` is only valid when ``mode=control``, $ total: 3 errors, 0 warnings, 13 lines checked Patch 25/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/28 Checking commit 39053391bc92 (configure: Avoid error messages about missing *-config-*.h files) 27/28 Checking commit bbddd33c414c (hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio) 28/28 Checking commit 0fa080f1883b (gitlab-ci: use --meson=git for CFI jobs) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210524164131.383778-1-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Mon, 24 May 2021 at 17:54, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit 371ebfe28600fc5a435504b841cd401208a68f07: > > Merge remote-tracking branch 'remotes/xtensa/tags/20210521-xtensa' into staging (2021-05-24 12:00:33 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to b304cc9bc94950a4b9100634db6dc3c885f99216: > > gitlab-ci: use --meson=git for CFI jobs (2021-05-24 18:39:02 +0200) > > ---------------------------------------------------------------- > * submodule cleanups (Philippe, myself) > * tiny step towards a usable preconfig mode (myself) > * Kconfig and LOCK_GUARD cleanups (philippe) > * new x86 CPUID feature (Yang Zhong) > * "-object qtest" support (myself) > * Dirty ring support for KVM (Peter) > * Fixes for 6.0 command line parsing breakage (myself) > * Fix for macOS 11.3 SDK (Katsuhiro) > > ---------------------------------------------------------------- > Ali Shirvani via (1): > doc: Add notes about -mon option mode=control argument. ERROR: pull request includes commits attributed to list thanks -- PMM
The following changes since commit 371ebfe28600fc5a435504b841cd401208a68f07: Merge remote-tracking branch 'remotes/xtensa/tags/20210521-xtensa' into staging (2021-05-24 12:00:33 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to b304cc9bc94950a4b9100634db6dc3c885f99216: gitlab-ci: use --meson=git for CFI jobs (2021-05-24 18:39:02 +0200) ---------------------------------------------------------------- * submodule cleanups (Philippe, myself) * tiny step towards a usable preconfig mode (myself) * Kconfig and LOCK_GUARD cleanups (philippe) * new x86 CPUID feature (Yang Zhong) * "-object qtest" support (myself) * Dirty ring support for KVM (Peter) * Fixes for 6.0 command line parsing breakage (myself) * Fix for macOS 11.3 SDK (Katsuhiro) ---------------------------------------------------------------- Ali Shirvani via (1): doc: Add notes about -mon option mode=control argument. Katsuhiro Ueno (1): meson: Set implicit_include_directories to false Kit Westneat (1): hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio Paolo Bonzini (10): configure: check for submodules if --with-git-submodules=ignore configure: simplify assignment to GIT_SUBMODULES object: add more commands to preconfig mode qtest: add a QOM object for qtest KVM: do not allow setting properties at runtime remove qemu-options* from root directory replication: move include out of root directory vl: allow not specifying size in -m when using -M memory-backend qemu-config: load modules when instantiating option groups gitlab-ci: use --meson=git for CFI jobs Peter Xu (10): memory: Introduce log_sync_global() to memory listener KVM: Use a big lock to replace per-kml slots_lock KVM: Create the KVMSlot dirty bitmap on flag changes KVM: Provide helper to get kvm dirty log KVM: Provide helper to sync dirty bitmap from slot to ramblock KVM: Simplify dirty log sync in kvm_set_phys_mem KVM: Cache kvm slot dirty bitmap size KVM: Add dirty-ring-size property KVM: Disable manual dirty log when dirty ring enabled KVM: Dirty ring support Philippe Mathieu-Daudé (3): configure: Only clone softfloat-3 repositories if TCG is enabled hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' tests/qtest/fuzz: Fix build failure Thomas Huth (1): configure: Avoid error messages about missing *-config-*.h files Yang Zhong (1): i386/cpu: Expose AVX_VNNI instruction to guest .gitlab-ci.yml | 4 +- Makefile | 2 + accel/kvm/kvm-all.c | 615 ++++++++++++++++++++++---- accel/kvm/trace-events | 7 + block/replication.c | 2 +- configure | 79 ++-- default-configs/devices/ppc64-softmmu.mak | 1 - hmp-commands.hx | 2 + hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 - hw/ppc/Kconfig | 1 + hw/scsi/scsi-disk.c | 12 +- replication.h => include/block/replication.h | 4 +- include/exec/memory.h | 12 + include/hw/core/cpu.h | 7 + include/qemu/config-file.h | 2 +- qemu-options.h => include/qemu/qemu-options.h | 9 +- include/sysemu/kvm_int.h | 7 +- meson.build | 1 + migration/colo.c | 2 +- os-posix.c | 2 +- os-win32.c | 1 - qapi/qom.json | 23 +- qemu-options-wrapper.h | 40 -- qemu-options.hx | 23 +- replication.c | 2 +- softmmu/memory.c | 33 +- softmmu/qtest.c | 185 +++++++- softmmu/vl.c | 52 ++- stubs/meson.build | 1 + stubs/module-opts.c | 6 + target/i386/cpu.c | 4 +- target/i386/cpu.h | 2 + tests/qtest/fuzz/fuzz.c | 1 + tests/unit/test-replication.c | 2 +- util/qemu-config.c | 1 + 37 files changed, 924 insertions(+), 227 deletions(-) rename replication.h => include/block/replication.h (98%) rename qemu-options.h => include/qemu/qemu-options.h (88%) delete mode 100644 qemu-options-wrapper.h create mode 100644 stubs/module-opts.c