| Message ID | 20210524112740.19330-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC] ALSA: hda: Add Lenovo ThinkStation P340 to power_save_denylist | expand |
Hi, On 5/24/2021 2:27 PM, Peter Ujfalusi wrote: > On playback start there is a huge plock/pop noise via the green jack used > in Line out mode. > > The only way I was able to fix it to set the power_save to 0 for the > snd_hda_intel. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > --- > Hi Takashi, > > ever since I have this workstation the plock/pop noise on playback start bugged > me. So far the only solution I have found is to disable the power_save which > I find acceptable on a desktop compared to the pops. > > The alsa-info.sh output is can be found here: > http://alsa-project.org/db/?f=414b1b236fc73db386ad4f938bc3b304f6b30b05 > > The machine have ALC623 codec and the jacks are correctly discovered and they > do what they supposed to be. > When I have the headset connected to the front and audio is routed there the > line out (green jack) from the back still prodices the plock/pop. > > Is there a known quirk for similar issue or a better way to handle it? > > Thanks you, > Peter Ujfalusi > > sound/pci/hda/hda_intel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 79ade335c8a0..e16d93d8291f 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2213,6 +2213,8 @@ static const struct snd_pci_quirk power_save_denylist[] = { > SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0), > /* https://bugs.launchpad.net/bugs/1821663 */ > SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), > + /* Loud pluck/pop noise via the green jack on playback start */ > + SND_PCI_QUIRK(0x8086, 0x06c8, "Lenovo ThinkStation P340", 0), The PCI ID might be wrong here: # lspci -nnk | grep -A2 Audio 00:1f.3 Audio device [0403]: Intel Corporation Comet Lake PCH cAVS [8086:06c8] DeviceName: Onboard - Sound Subsystem: Lenovo Device [17aa:1048] 0x17aa:0x1048 is the correct one. alsa-info failed to pick up the CPU, it is i9-10900k > {} > }; > #endif /* CONFIG_PM */ >
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 79ade335c8a0..e16d93d8291f 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2213,6 +2213,8 @@ static const struct snd_pci_quirk power_save_denylist[] = { SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0), /* https://bugs.launchpad.net/bugs/1821663 */ SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), + /* Loud pluck/pop noise via the green jack on playback start */ + SND_PCI_QUIRK(0x8086, 0x06c8, "Lenovo ThinkStation P340", 0), {} }; #endif /* CONFIG_PM */
On playback start there is a huge plock/pop noise via the green jack used in Line out mode. The only way I was able to fix it to set the power_save to 0 for the snd_hda_intel. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> --- Hi Takashi, ever since I have this workstation the plock/pop noise on playback start bugged me. So far the only solution I have found is to disable the power_save which I find acceptable on a desktop compared to the pops. The alsa-info.sh output is can be found here: http://alsa-project.org/db/?f=414b1b236fc73db386ad4f938bc3b304f6b30b05 The machine have ALC623 codec and the jacks are correctly discovered and they do what they supposed to be. When I have the headset connected to the front and audio is routed there the line out (green jack) from the back still prodices the plock/pop. Is there a known quirk for similar issue or a better way to handle it? Thanks you, Peter Ujfalusi sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+)