[0/3] testing block device blocksizes

Message

Kit Westneat May 25, 2021, 12:47 p.m. UTC

These patches add a few parameters to blkdebug to allow modification of
the block device block sizes, both logical and physical. It also adds a
test that uses the parameter to verify correct UNMAP behavior in devices
with 4k blocks.

Kit Westneat (3):
  block/blkdebug: add blocksize parameter
  tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test
  block/blkdebug: add log-blocksize and phys-blocksize parameters

 block/blkdebug.c               | 53 ++++++++++++++++++++++++++++++++++
 tests/qtest/virtio-scsi-test.c | 48 ++++++++++++++++++++++++++++++
 2 files changed, 101 insertions(+)

Comments

[e-mail] May 25, 2021, 12:54 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH 0/3] testing block device blocksizes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
8319440 block/blkdebug: add log-blocksize and phys-blocksize parameters
e09eac6 tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test
0442070 block/blkdebug: add blocksize parameter

=== OUTPUT BEGIN ===
1/3 Checking commit 0442070571e5 (block/blkdebug: add blocksize parameter)
WARNING: line over 80 characters
#44: FILE: block/blkdebug.c:572:
+    if (s->blocksize && (s->blocksize >= INT_MAX || !is_power_of_2(s->blocksize))) {

ERROR: braces {} are necessary for all arms of this statement
#61: FILE: block/blkdebug.c:1004:
+    if (!s->blocksize)
[...]

total: 1 errors, 1 warnings, 63 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit e09eac6b4197 (tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test)
ERROR: do not use C99 // comments
#33: FILE: tests/qtest/virtio-scsi-test.c:213:
+    // default null-co device size is 2**30

ERROR: do not use C99 // comments
#34: FILE: tests/qtest/virtio-scsi-test.c:214:
+    // LBA 0x7fff is ~ 1/8 into device, with 4k blocks

ERROR: do not use C99 // comments
#35: FILE: tests/qtest/virtio-scsi-test.c:215:
+    // if check_lba_range incorrectly using 512 bytes, will trigger sense error

ERROR: do not use C99 // comments
#37: FILE: tests/qtest/virtio-scsi-test.c:217:
+        0x00, 0x16, // unmap data length

ERROR: do not use C99 // comments
#38: FILE: tests/qtest/virtio-scsi-test.c:218:
+        0x00, 0x10, // unmap block descriptor data length

ERROR: do not use C99 // comments
#39: FILE: tests/qtest/virtio-scsi-test.c:219:
+        0x00, 0x00, 0x00, 0x00, // reserved

ERROR: do not use C99 // comments
#40: FILE: tests/qtest/virtio-scsi-test.c:220:
+        0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x7f, 0xff, // LBA

ERROR: do not use C99 // comments
#41: FILE: tests/qtest/virtio-scsi-test.c:221:
+        0x00, 0x00, 0x03, 0xff, // sector count

ERROR: do not use C99 // comments
#42: FILE: tests/qtest/virtio-scsi-test.c:222:
+        0x00, 0x00, 0x00, 0x00, //reserved

total: 9 errors, 0 warnings, 66 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 8319440a28b2 (block/blkdebug: add log-blocksize and phys-blocksize parameters)
ERROR: line over 90 characters
#53: FILE: block/blkdebug.c:591:
+    if (s->phys_blocksize && (s->phys_blocksize >= INT_MAX || !is_power_of_2(s->phys_blocksize))) {

ERROR: line over 90 characters
#60: FILE: block/blkdebug.c:598:
+    if (s->log_blocksize && (s->log_blocksize >= INT_MAX || !is_power_of_2(s->log_blocksize))) {

total: 2 errors, 0 warnings, 67 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]