| Message ID | 20210512231241.2816122-19-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | python: create installable package | expand |
On Wed, May 12, 2021 at 07:12:34PM -0400, John Snow wrote: > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret > certain "from ..." clauses that are not related to imports. > > isort < 5.1.1 has a bug where it does not handle comments near import > statements correctly. > > Require 5.1.2 or greater. > > isort can be run with 'isort -c qemu' from the python root. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > python/Pipfile | 1 + > python/Pipfile.lock | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Cleber Rosa <crosa@redhat.com>
On 5/25/21 11:56 AM, Cleber Rosa wrote: > On Wed, May 12, 2021 at 07:12:34PM -0400, John Snow wrote: >> isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret >> certain "from ..." clauses that are not related to imports. >> >> isort < 5.1.1 has a bug where it does not handle comments near import >> statements correctly. >> >> Require 5.1.2 or greater. >> >> isort can be run with 'isort -c qemu' from the python root. >> >> Signed-off-by: John Snow <jsnow@redhat.com> >> --- >> python/Pipfile | 1 + >> python/Pipfile.lock | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > Reviewed-by: Cleber Rosa <crosa@redhat.com> > Thanks. I have also updated the commit message a little bit: isort can be run (in "check" mode) with 'isort -c qemu' from the python root. isort can also be used to fix/rewrite import order automatically by using 'isort qemu'. --js
On Tue, May 25, 2021 at 01:21:25PM -0400, John Snow wrote: > On 5/25/21 11:56 AM, Cleber Rosa wrote: > > On Wed, May 12, 2021 at 07:12:34PM -0400, John Snow wrote: > > > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret > > > certain "from ..." clauses that are not related to imports. > > > > > > isort < 5.1.1 has a bug where it does not handle comments near import > > > statements correctly. > > > > > > Require 5.1.2 or greater. > > > > > > isort can be run with 'isort -c qemu' from the python root. > > > > > > Signed-off-by: John Snow <jsnow@redhat.com> > > > --- > > > python/Pipfile | 1 + > > > python/Pipfile.lock | 4 ++-- > > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > Reviewed-by: Cleber Rosa <crosa@redhat.com> > > > > Thanks. I have also updated the commit message a little bit: > > isort can be run (in "check" mode) with 'isort -c qemu' from the python > root. isort can also be used to fix/rewrite import order automatically > by using 'isort qemu'. > > --js OK, sounds even better! - Cleber.
diff --git a/python/Pipfile b/python/Pipfile index bb2e34b381d..fb7c8d142ee 100644 --- a/python/Pipfile +++ b/python/Pipfile @@ -5,6 +5,7 @@ verify_ssl = true [dev-packages] flake8 = ">=3.6.0" +isort = ">=5.1.2" mypy = ">=0.770" pylint = ">=2.7.0" diff --git a/python/Pipfile.lock b/python/Pipfile.lock index 2b1567b359c..030d5683147 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -1,7 +1,7 @@ { "_meta": { "hash": { - "sha256": "5e5b76eb2f6d8e833b79d9f083f08e0087b3e663275a00b84a6799419aa8a776" + "sha256": "e1f54e4d7fc287bdff731659614f5f9bbea2f1aee122ba04506ab26c4007440e" }, "pipfile-spec": 6, "requires": { @@ -46,7 +46,7 @@ "sha256:0a943902919f65c5684ac4e0154b1ad4fac6dcaa5d9f3426b732f1c8b5419be6", "sha256:2bb1680aad211e3c9944dbce1d4ba09a989f04e238296c87fe2139faa26d655d" ], - "markers": "python_version >= '3.6' and python_version < '4.0'", + "index": "pypi", "version": "==5.8.0" }, "lazy-object-proxy": {
isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret certain "from ..." clauses that are not related to imports. isort < 5.1.1 has a bug where it does not handle comments near import statements correctly. Require 5.1.2 or greater. isort can be run with 'isort -c qemu' from the python root. Signed-off-by: John Snow <jsnow@redhat.com> --- python/Pipfile | 1 + python/Pipfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)