| Message ID | 20210525221955.265524-8-kent.overstreet@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Tue, May 25, 2021 at 06:19:55PM -0400, Kent Overstreet wrote: > This probably should be in every test that uses the scratch device. Um, it is -- ./check runs fsck on the test and scratch devices if you _require_test or _require_scratch'd them (which this test does). What weird output did you see? --D > Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com> > --- > tests/generic/269 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/generic/269 b/tests/generic/269 > index aec573c06a..484a26f89f 100755 > --- a/tests/generic/269 > +++ b/tests/generic/269 > @@ -63,5 +63,7 @@ if ! _scratch_unmount; then > status=1 > exit > fi > + > +_check_scratch_fs > status=0 > exit > -- > 2.32.0.rc0 >
On Tue, May 25, 2021 at 06:34:18PM -0700, Darrick J. Wong wrote: > On Tue, May 25, 2021 at 06:19:55PM -0400, Kent Overstreet wrote: > > This probably should be in every test that uses the scratch device. > > Um, it is -- ./check runs fsck on the test and scratch devices if you > _require_test or _require_scratch'd them (which this test does). What > weird output did you see? I could've sworn I had generic/269 pass until I adedd that, but I just rechecked and it's doing what you describe - my bad, I'll drop this one.
diff --git a/tests/generic/269 b/tests/generic/269 index aec573c06a..484a26f89f 100755 --- a/tests/generic/269 +++ b/tests/generic/269 @@ -63,5 +63,7 @@ if ! _scratch_unmount; then status=1 exit fi + +_check_scratch_fs status=0 exit
This probably should be in every test that uses the scratch device. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com> --- tests/generic/269 | 2 ++ 1 file changed, 2 insertions(+)