| Message ID | 20210331155520.2987823-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b26b48749b18eedb079866c94c4ea99e6a9ef52c |
| Headers | show |
| Series | [V2] soundwire: qcom: use signed variable for error return | expand |
On 3/31/21 10:55 AM, Vinod Koul wrote: > We get warning of using a unsigned variable being compared to less than > zero. The comparison is correct as it checks for errors from previous > call to qcom_swrm_get_alert_slave_dev_num(), so we should use a signed > variable here. > > While at it, drop the superfluous initialization as well > > drivers/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible > condition '(devnum < 0) => (0-255 < 0)' > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index b08ecb9b418c..ec86c4e53fdb 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > struct qcom_swrm_ctrl *swrm = dev_id; > u32 value, intr_sts, intr_sts_masked, slave_status; > u32 i; > - u8 devnum = 0; > + int devnum; > int ret = IRQ_HANDLED; > > swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts); >
On Wed 31 Mar 10:55 CDT 2021, Vinod Koul wrote: > We get warning of using a unsigned variable being compared to less than > zero. The comparison is correct as it checks for errors from previous > call to qcom_swrm_get_alert_slave_dev_num(), so we should use a signed > variable here. > > While at it, drop the superfluous initialization as well > > drivers/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible > condition '(devnum < 0) => (0-255 < 0)' > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index b08ecb9b418c..ec86c4e53fdb 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > struct qcom_swrm_ctrl *swrm = dev_id; > u32 value, intr_sts, intr_sts_masked, slave_status; > u32 i; > - u8 devnum = 0; > + int devnum; > int ret = IRQ_HANDLED; > > swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts); > -- > 2.26.3 >
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Wed, 31 Mar 2021 21:25:20 +0530 you wrote: > We get warning of using a unsigned variable being compared to less than > zero. The comparison is correct as it checks for errors from previous > call to qcom_swrm_get_alert_slave_dev_num(), so we should use a signed > variable here. > > While at it, drop the superfluous initialization as well > > [...] Here is the summary with links: - [V2] soundwire: qcom: use signed variable for error return https://git.kernel.org/qcom/c/b26b48749b18 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index b08ecb9b418c..ec86c4e53fdb 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) struct qcom_swrm_ctrl *swrm = dev_id; u32 value, intr_sts, intr_sts_masked, slave_status; u32 i; - u8 devnum = 0; + int devnum; int ret = IRQ_HANDLED; swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts);
We get warning of using a unsigned variable being compared to less than zero. The comparison is correct as it checks for errors from previous call to qcom_swrm_get_alert_slave_dev_num(), so we should use a signed variable here. While at it, drop the superfluous initialization as well drivers/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible condition '(devnum < 0) => (0-255 < 0)' Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)