diff mbox series

[1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc

Message ID 20210601095403.236007-1-krzysztof.kozlowski@canonical.com (mailing list archive)
State New, archived
Headers show
Series [1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc | expand

Commit Message

Krzysztof Kozlowski June 1, 2021, 9:54 a.m. UTC
The is_imx6q_usdhc() function is unused:

  drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function 'is_imx6q_usdhc'

Reported-by: kernel test robot <lkp@intel.com>
Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bough Chen June 1, 2021, 11:59 a.m. UTC | #1
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
> Sent: 2021年6月1日 17:54
> To: Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> dl-linux-imx <linux-imx@nxp.com>; Orson Zhai <orsonzhai@gmail.com>;
> Baolin Wang <baolin.wang7@gmail.com>; Chunyan Zhang
> <zhang.lyra@gmail.com>; linux-mmc@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; kernel test
> robot <lkp@intel.com>
> Subject: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc
> 
> The is_imx6q_usdhc() function is unused:
> 
>   drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function
> 'is_imx6q_usdhc'

Reviewed-by: Haibo Chen <haibo.chen@nxp.com>

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct
> pltfm_imx_data *data)
>  	return data->socdata == &esdhc_imx53_data;  }
> 
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data) -{
> -	return data->socdata == &usdhc_imx6q_data;
> -}
> -
>  static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)  {
>  	return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
Ulf Hansson June 8, 2021, 1:16 p.m. UTC | #2
On Tue, 1 Jun 2021 at 11:54, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The is_imx6q_usdhc() function is unused:
>
>   drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function 'is_imx6q_usdhc'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct pltfm_imx_data *data)
>         return data->socdata == &esdhc_imx53_data;
>  }
>
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)
> -{
> -       return data->socdata == &usdhc_imx6q_data;
> -}
> -
>  static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)
>  {
>         return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index fba4a963d12e..7336ae749137 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -324,11 +324,6 @@  static inline int is_imx53_esdhc(struct pltfm_imx_data *data)
 	return data->socdata == &esdhc_imx53_data;
 }
 
-static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)
-{
-	return data->socdata == &usdhc_imx6q_data;
-}
-
 static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)
 {
 	return !!(data->socdata->flags & ESDHC_FLAG_USDHC);