| Message ID | 20210305095657.GA142006@embeddedor (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,next] drm/nouveau: Fix fall-through warnings for Clang | expand |
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:56, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a couple of break statements instead > of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 2375711877cf..62903c3b368d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > break; > case TTM_PL_TT: > error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 61e6d7412505..eb844cdcaec2 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > default: > break; > } > + break; > case DRM_MODE_SCALE_FULLSCREEN: > case DRM_MODE_SCALE_CENTER: > case DRM_MODE_SCALE_ASPECT: >
Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >> of warnings by explicitly adding a couple of break statements instead >> of letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >> index 2375711877cf..62903c3b368d 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >> break; >> case TTM_PL_TT: >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >> + break; >> default: >> break; >> } >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >> index 61e6d7412505..eb844cdcaec2 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >> default: >> break; >> } >> + break; >> case DRM_MODE_SCALE_FULLSCREEN: >> case DRM_MODE_SCALE_CENTER: >> case DRM_MODE_SCALE_ASPECT: >>
all three nouveau patches are Reviewed-by: Karol Herbst <kherbst@redhat.com> and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau >
On 6/1/21 19:10, Karol Herbst wrote: > all three nouveau patches are > > Reviewed-by: Karol Herbst <kherbst@redhat.com> > > and I don't think anybody would mind if those get into through other > trees, but maybe drm-mist would be a good place for it if other > patches involve other drm drivers? No other person has replied after pinging multiple times and resending these patches, so I guess people don't care. I'll add this and the other similar patches to my -next branch for 5.14. Thanks, Karol. -- Gustavo > > On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Hi, >> >> Friendly second ping: who can take this? >> >> I can add this to my -next branch for 5.14 if you don't mind. >> >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 23 in linux-next. This is one of those last remaining warnings. >> >> Thanks >> -- >> Gustavo >> >> On 4/20/21 15:13, Gustavo A. R. Silva wrote: >>> Hi all, >>> >>> Friendly ping: who can take this, please? >>> >>> Thanks >>> -- >>> Gustavo >>> >>> On 3/5/21 03:56, Gustavo A. R. Silva wrote: >>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >>>> of warnings by explicitly adding a couple of break statements instead >>>> of letting the code fall through to the next case. >>>> >>>> Link: https://github.com/KSPP/linux/issues/115 >>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>>> --- >>>> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >>>> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> index 2375711877cf..62903c3b368d 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >>>> break; >>>> case TTM_PL_TT: >>>> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >>>> + break; >>>> default: >>>> break; >>>> } >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> index 61e6d7412505..eb844cdcaec2 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >>>> default: >>>> break; >>>> } >>>> + break; >>>> case DRM_MODE_SCALE_FULLSCREEN: >>>> case DRM_MODE_SCALE_CENTER: >>>> case DRM_MODE_SCALE_ASPECT: >>>> >> _______________________________________________ >> Nouveau mailing list >> Nouveau@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau >> >
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 2375711877cf..62903c3b368d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) break; case TTM_PL_TT: error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); + break; default: break; } diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 61e6d7412505..eb844cdcaec2 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, default: break; } + break; case DRM_MODE_SCALE_FULLSCREEN: case DRM_MODE_SCALE_CENTER: case DRM_MODE_SCALE_ASPECT:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 2 files changed, 2 insertions(+)