| Message ID | 20210602113643.3037374-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 45ce213392df07b9e2443666c0910e1617882cf3 |
| Headers | show |
| Series | [-next] ASoC: rk817: Constify static struct snd_soc_dai_ops | expand |
On Wed, Jun 02, 2021 at 11:36:43AM +0000, Wei Yongjun wrote: > The snd_soc_dai_ops structures is only stored in the ops field of a > snd_soc_dai_driver structure, so make the snd_soc_dai_ops structure > const to allow the compiler to put it in read-only memory. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Tested-by: Chris Morgan <macromorgan@hotmail.com> Works for me when I apply it to my tree. Tested audio playback and recording still work and no warnings are introduced. > --- > sound/soc/codecs/rk817_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c > index 17e672b85ee5..9a896e4326c3 100644 > --- a/sound/soc/codecs/rk817_codec.c > +++ b/sound/soc/codecs/rk817_codec.c > @@ -382,7 +382,7 @@ static int rk817_digital_mute(struct snd_soc_dai *dai, int mute, int stream) > SNDRV_PCM_FMTBIT_S24_LE |\ > SNDRV_PCM_FMTBIT_S32_LE) > > -static struct snd_soc_dai_ops rk817_dai_ops = { > +static const struct snd_soc_dai_ops rk817_dai_ops = { > .hw_params = rk817_hw_params, > .set_fmt = rk817_set_dai_fmt, > .set_sysclk = rk817_set_dai_sysclk, >
On Wed, 2 Jun 2021 11:36:43 +0000, Wei Yongjun wrote: > The snd_soc_dai_ops structures is only stored in the ops field of a > snd_soc_dai_driver structure, so make the snd_soc_dai_ops structure > const to allow the compiler to put it in read-only memory. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: rk817: Constify static struct snd_soc_dai_ops commit: 45ce213392df07b9e2443666c0910e1617882cf3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c index 17e672b85ee5..9a896e4326c3 100644 --- a/sound/soc/codecs/rk817_codec.c +++ b/sound/soc/codecs/rk817_codec.c @@ -382,7 +382,7 @@ static int rk817_digital_mute(struct snd_soc_dai *dai, int mute, int stream) SNDRV_PCM_FMTBIT_S24_LE |\ SNDRV_PCM_FMTBIT_S32_LE) -static struct snd_soc_dai_ops rk817_dai_ops = { +static const struct snd_soc_dai_ops rk817_dai_ops = { .hw_params = rk817_hw_params, .set_fmt = rk817_set_dai_fmt, .set_sysclk = rk817_set_dai_sysclk,
The snd_soc_dai_ops structures is only stored in the ops field of a snd_soc_dai_driver structure, so make the snd_soc_dai_ops structure const to allow the compiler to put it in read-only memory. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- sound/soc/codecs/rk817_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)