| Message ID | 20210602214645.695597-1-keescook@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi/arm64: Mark next_platform_timer as __init | expand |
On 2021/6/3 5:46, Kees Cook wrote: > Fix section mismatch warning: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc > The function next_platform_timer() references > the variable __initdata acpi_gtdt_desc. > This is often because next_platform_timer lacks a __initdata > annotation or the annotation of acpi_gtdt_desc is wrong. > > Suggested-by: Hanjun Guo <guohanjun@huawei.com> > Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/ > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > drivers/acpi/arm64/gtdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index 0a0a982f9c28..c3ad42470a7c 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor { > > static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata; > > -static inline void *next_platform_timer(void *platform_timer) > +static __init void *next_platform_timer(void *platform_timer) > { > struct acpi_gtdt_header *gh = platform_timer; Thanks for the fix, Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c index 0a0a982f9c28..c3ad42470a7c 100644 --- a/drivers/acpi/arm64/gtdt.c +++ b/drivers/acpi/arm64/gtdt.c @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor { static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata; -static inline void *next_platform_timer(void *platform_timer) +static __init void *next_platform_timer(void *platform_timer) { struct acpi_gtdt_header *gh = platform_timer;
Fix section mismatch warning: WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc The function next_platform_timer() references the variable __initdata acpi_gtdt_desc. This is often because next_platform_timer lacks a __initdata annotation or the annotation of acpi_gtdt_desc is wrong. Suggested-by: Hanjun Guo <guohanjun@huawei.com> Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/ Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/acpi/arm64/gtdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)