| Message ID | 20210519093303.10789-2-johan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 18538a50239b11f07befa18073e00fda3040195c |
| Headers | show |
| Series | USB: drop irq-flags initialisations | expand |
Hi, Johan Hovold <johan@kernel.org> writes: > There's no need to initialise irq-flags variables before saving the > interrupt state. > > Cc: Pawel Laszczak <pawell@cadence.com> > Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Felipe Balbi <balbi@kernel.org>
diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c index 56707b6b0f57..4fddc78f732f 100644 --- a/drivers/usb/cdns3/cdnsp-gadget.c +++ b/drivers/usb/cdns3/cdnsp-gadget.c @@ -1151,7 +1151,7 @@ static int cdnsp_gadget_ep_set_halt(struct usb_ep *ep, int value) struct cdnsp_ep *pep = to_cdnsp_ep(ep); struct cdnsp_device *pdev = pep->pdev; struct cdnsp_request *preq; - unsigned long flags = 0; + unsigned long flags; int ret; spin_lock_irqsave(&pdev->lock, flags); @@ -1176,7 +1176,7 @@ static int cdnsp_gadget_ep_set_wedge(struct usb_ep *ep) { struct cdnsp_ep *pep = to_cdnsp_ep(ep); struct cdnsp_device *pdev = pep->pdev; - unsigned long flags = 0; + unsigned long flags; int ret; spin_lock_irqsave(&pdev->lock, flags);
There's no need to initialise irq-flags variables before saving the interrupt state. Cc: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/usb/cdns3/cdnsp-gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)