diff mbox series

spi: stm32-qspi: Fix W=1 build warning

Message ID 20210604075009.25914-1-patrice.chotard@foss.st.com (mailing list archive)
State Accepted
Commit 6829222b408f5aa5222c18ea3f492cac19fa9405
Headers show
Series spi: stm32-qspi: Fix W=1 build warning | expand

Commit Message

Patrice CHOTARD June 4, 2021, 7:50 a.m. UTC 
From: Patrice Chotard <patrice.chotard@foss.st.com>

Fix the following compilation warning using W=1 build:
arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap June 4, 2021, 3:27 p.m. UTC | #1 
On 6/4/21 12:50 AM, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>

This is a build error, not a warning. The complete message is:

ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'


Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


thanks.

> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
>  	tristate "STMicroelectronics STM32 QUAD SPI controller"
>  	depends on ARCH_STM32 || COMPILE_TEST
>  	depends on OF
> +	depends on SPI_MEM
>  	help
>  	  This enables support for the Quad SPI controller in master mode.
>  	  This driver does not support generic SPI. The implementation only
>
Mark Brown June 4, 2021, 4:32 p.m. UTC | #2 
On Fri, 4 Jun 2021 09:50:09 +0200, patrice.chotard@foss.st.com wrote:
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: stm32-qspi: Fix W=1 build warning
      commit: 6829222b408f5aa5222c18ea3f492cac19fa9405

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f4481fe48bf0..e71a4c514f7b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -806,6 +806,7 @@  config SPI_STM32_QSPI
 	tristate "STMicroelectronics STM32 QUAD SPI controller"
 	depends on ARCH_STM32 || COMPILE_TEST
 	depends on OF
+	depends on SPI_MEM
 	help
 	  This enables support for the Quad SPI controller in master mode.
 	  This driver does not support generic SPI. The implementation only