mbox series

[0/5,v2] secilc/cil: Fix name resolution for macro calls

Message ID 20210511200301.407855-1-jwcart2@gmail.com (mailing list archive)
Headers show
Series secilc/cil: Fix name resolution for macro calls | expand

Message

James Carter May 11, 2021, 8:02 p.m. UTC 
This patch series fixes name resolution within expanded macro calls and
with call arguments.

The first patch is same as in v1.
Patches 2-4 replace patch 2 in v1. The original way of fixing name
resolution of call arguments did not work if a disabled optional
forced a reset.
Patch 5 is the same as patch 3 in v1.

James Carter (5):
  libsepol/cil: Make name resolution in macros work as documented
  libsepol/cil: Do not add NULL node when inserting key into symtab
  libsepo/cil: Refactor macro call resolution
  libsepol/cil: Do not resolve arguments to declarations in the call
  secilc/docs: Relocate and reword macro call name resolution order

 libsepol/cil/src/cil_internal.h          |   1 -
 libsepol/cil/src/cil_resolve_ast.c       | 635 ++++++++++++-----------
 libsepol/cil/src/cil_symtab.c            |   8 +-
 secilc/docs/cil_call_macro_statements.md |  24 +-
 4 files changed, 354 insertions(+), 314 deletions(-)

Comments

James Carter June 3, 2021, 5:06 p.m. UTC | #1 
On Tue, May 11, 2021 at 4:03 PM James Carter <jwcart2@gmail.com> wrote:
>
> This patch series fixes name resolution within expanded macro calls and
> with call arguments.
>
> The first patch is same as in v1.
> Patches 2-4 replace patch 2 in v1. The original way of fixing name
> resolution of call arguments did not work if a disabled optional
> forced a reset.
> Patch 5 is the same as patch 3 in v1.
>
> James Carter (5):
>   libsepol/cil: Make name resolution in macros work as documented
>   libsepol/cil: Do not add NULL node when inserting key into symtab
>   libsepo/cil: Refactor macro call resolution
>   libsepol/cil: Do not resolve arguments to declarations in the call
>   secilc/docs: Relocate and reword macro call name resolution order
>
>  libsepol/cil/src/cil_internal.h          |   1 -
>  libsepol/cil/src/cil_resolve_ast.c       | 635 ++++++++++++-----------
>  libsepol/cil/src/cil_symtab.c            |   8 +-
>  secilc/docs/cil_call_macro_statements.md |  24 +-
>  4 files changed, 354 insertions(+), 314 deletions(-)
>
> --
> 2.26.3
>

There hasn't been any comments on this series, and it has been more
than three weeks since I sent it, so I plan on merging it tomorrow.
Jim
James Carter June 4, 2021, 4:59 p.m. UTC | #2 
On Thu, Jun 3, 2021 at 1:06 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Tue, May 11, 2021 at 4:03 PM James Carter <jwcart2@gmail.com> wrote:
> >
> > This patch series fixes name resolution within expanded macro calls and
> > with call arguments.
> >
> > The first patch is same as in v1.
> > Patches 2-4 replace patch 2 in v1. The original way of fixing name
> > resolution of call arguments did not work if a disabled optional
> > forced a reset.
> > Patch 5 is the same as patch 3 in v1.
> >
> > James Carter (5):
> >   libsepol/cil: Make name resolution in macros work as documented
> >   libsepol/cil: Do not add NULL node when inserting key into symtab
> >   libsepo/cil: Refactor macro call resolution
> >   libsepol/cil: Do not resolve arguments to declarations in the call
> >   secilc/docs: Relocate and reword macro call name resolution order
> >
> >  libsepol/cil/src/cil_internal.h          |   1 -
> >  libsepol/cil/src/cil_resolve_ast.c       | 635 ++++++++++++-----------
> >  libsepol/cil/src/cil_symtab.c            |   8 +-
> >  secilc/docs/cil_call_macro_statements.md |  24 +-
> >  4 files changed, 354 insertions(+), 314 deletions(-)
> >
> > --
> > 2.26.3
> >
>
> There hasn't been any comments on this series, and it has been more
> than three weeks since I sent it, so I plan on merging it tomorrow.
> Jim

This series has been merged.
Jim