Message ID | 20210607180356.165785-1-matthew.brost@intel.com (mailing list archive) |
---|---|
Headers | show |
Series | Update firmware to v62.0.0 | expand |
On 6/7/2021 11:03 AM, Matthew Brost wrote: > As part of enabling GuC submission [1] we need to update to the latest > and greatest firmware. This series does that. This is a destructive > change. e.g. Without all the patches in this series it will break the > i915 driver. As such, after we review all of these patches they will > squashed into a single patch for merging. Can you resubmit with an added HAX patch for enable_guc=2 after the first round of review? none of the machines in CI seems to have attempted to load the guc, not even cfl-guc and kbl-guc. If all the reviews are good maybe just resubmit the squashed patch and the enablement with a CI tag, so we can merge once we get the results. Daniele > > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > > [1] https://patchwork.freedesktop.org/series/89844/ > > John Harrison (3): > drm/i915/guc: Support per context scheduling policies > drm/i915/guc: Unified GuC log > drm/i915/guc: Update firmware to v62.0.0 > > Michal Wajdeczko (10): > drm/i915/guc: Introduce unified HXG messages > drm/i915/guc: Update MMIO based communication > drm/i915/guc: Update CTB response status definition > drm/i915/guc: Add flag for mark broken CTB > drm/i915/guc: New definition of the CTB descriptor > drm/i915/guc: New definition of the CTB registration action > drm/i915/guc: New CTB based communication > drm/i915/doc: Include GuC ABI documentation > drm/i915/guc: Kill guc_clients.ct_pool > drm/i915/guc: Kill ads.client_info > > Documentation/gpu/i915.rst | 8 + > .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107 ++++++ > .../gt/uc/abi/guc_communication_ctb_abi.h | 130 +++++-- > .../gt/uc/abi/guc_communication_mmio_abi.h | 63 ++-- > .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++ > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 107 ++++-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 45 +-- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 355 +++++++++--------- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 75 +--- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 6 +- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26 +- > 13 files changed, 750 insertions(+), 420 deletions(-) >
On Mon, Jun 07, 2021 at 03:19:11PM -0700, Daniele Ceraolo Spurio wrote: > > > On 6/7/2021 11:03 AM, Matthew Brost wrote: > > As part of enabling GuC submission [1] we need to update to the latest > > and greatest firmware. This series does that. This is a destructive > > change. e.g. Without all the patches in this series it will break the > > i915 driver. As such, after we review all of these patches they will > > squashed into a single patch for merging. > > Can you resubmit with an added HAX patch for enable_guc=2 after the first > round of review? none of the machines in CI seems to have attempted to load > the guc, not even cfl-guc and kbl-guc. If all the reviews are good maybe > just resubmit the squashed patch and the enablement with a CI tag, so we can > merge once we get the results. > Done on trybot, results looks good. https://patchwork.freedesktop.org/series/91341/ Matt > Daniele > > > > > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > > > > [1] https://patchwork.freedesktop.org/series/89844/ > > > > John Harrison (3): > > drm/i915/guc: Support per context scheduling policies > > drm/i915/guc: Unified GuC log > > drm/i915/guc: Update firmware to v62.0.0 > > > > Michal Wajdeczko (10): > > drm/i915/guc: Introduce unified HXG messages > > drm/i915/guc: Update MMIO based communication > > drm/i915/guc: Update CTB response status definition > > drm/i915/guc: Add flag for mark broken CTB > > drm/i915/guc: New definition of the CTB descriptor > > drm/i915/guc: New definition of the CTB registration action > > drm/i915/guc: New CTB based communication > > drm/i915/doc: Include GuC ABI documentation > > drm/i915/guc: Kill guc_clients.ct_pool > > drm/i915/guc: Kill ads.client_info > > > > Documentation/gpu/i915.rst | 8 + > > .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107 ++++++ > > .../gt/uc/abi/guc_communication_ctb_abi.h | 130 +++++-- > > .../gt/uc/abi/guc_communication_mmio_abi.h | 63 ++-- > > .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++ > > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 107 ++++-- > > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 45 +-- > > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 355 +++++++++--------- > > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 +- > > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 75 +--- > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 +- > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 6 +- > > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26 +- > > 13 files changed, 750 insertions(+), 420 deletions(-) > > >
As part of enabling GuC submission [1] we need to update to the latest and greatest firmware. This series does that. This is a destructive change. e.g. Without all the patches in this series it will break the i915 driver. As such, after we review all of these patches they will squashed into a single patch for merging. Signed-off-by: Matthew Brost <matthew.brost@intel.com> [1] https://patchwork.freedesktop.org/series/89844/ John Harrison (3): drm/i915/guc: Support per context scheduling policies drm/i915/guc: Unified GuC log drm/i915/guc: Update firmware to v62.0.0 Michal Wajdeczko (10): drm/i915/guc: Introduce unified HXG messages drm/i915/guc: Update MMIO based communication drm/i915/guc: Update CTB response status definition drm/i915/guc: Add flag for mark broken CTB drm/i915/guc: New definition of the CTB descriptor drm/i915/guc: New definition of the CTB registration action drm/i915/guc: New CTB based communication drm/i915/doc: Include GuC ABI documentation drm/i915/guc: Kill guc_clients.ct_pool drm/i915/guc: Kill ads.client_info Documentation/gpu/i915.rst | 8 + .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 107 ++++++ .../gt/uc/abi/guc_communication_ctb_abi.h | 130 +++++-- .../gt/uc/abi/guc_communication_mmio_abi.h | 63 ++-- .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 213 +++++++++++ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 107 ++++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 45 +-- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 355 +++++++++--------- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 75 +--- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 +- drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 6 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 26 +- 13 files changed, 750 insertions(+), 420 deletions(-)