| Message ID | 20210608230703.19510-2-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve I/O priority support | expand |
On 2021/06/09 8:07, Bart Van Assche wrote: > These entries were consecutive at the time of their introduction but are no > longer consecutive. Make these again consecutive. Additionally, modify the > help text since it refers to blk-mq and since the legacy block layer has > been removed. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/block/Kconfig b/block/Kconfig > index a2297edfdde8..6685578b2a20 100644 > --- a/block/Kconfig > +++ b/block/Kconfig > @@ -133,6 +133,13 @@ config BLK_WBT > dynamically on an algorithm loosely based on CoDel, factoring in > the realtime performance of the disk. > > +config BLK_WBT_MQ > + bool "Enable writeback throttling by default" > + default y > + depends on BLK_WBT > + help > + Enable writeback throttling by default for request-based block devices. > + > config BLK_CGROUP_IOLATENCY > bool "Enable support for latency based cgroup IO protection" > depends on BLK_CGROUP=y > @@ -155,13 +162,6 @@ config BLK_CGROUP_IOCOST > distributes IO capacity between different groups based on > their share of the overall weight distribution. > > -config BLK_WBT_MQ > - bool "Multiqueue writeback throttling" > - default y > - depends on BLK_WBT > - help > - Enable writeback throttling by default on multiqueue devices. > - > config BLK_DEBUG_FS > bool "Block layer debugging information in debugfs" > default y > Looks good. Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 6/9/21 1:06 AM, Bart Van Assche wrote: > These entries were consecutive at the time of their introduction but are no > longer consecutive. Make these again consecutive. Additionally, modify the > help text since it refers to blk-mq and since the legacy block layer has > been removed. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/block/Kconfig b/block/Kconfig index a2297edfdde8..6685578b2a20 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -133,6 +133,13 @@ config BLK_WBT dynamically on an algorithm loosely based on CoDel, factoring in the realtime performance of the disk. +config BLK_WBT_MQ + bool "Enable writeback throttling by default" + default y + depends on BLK_WBT + help + Enable writeback throttling by default for request-based block devices. + config BLK_CGROUP_IOLATENCY bool "Enable support for latency based cgroup IO protection" depends on BLK_CGROUP=y @@ -155,13 +162,6 @@ config BLK_CGROUP_IOCOST distributes IO capacity between different groups based on their share of the overall weight distribution. -config BLK_WBT_MQ - bool "Multiqueue writeback throttling" - default y - depends on BLK_WBT - help - Enable writeback throttling by default on multiqueue devices. - config BLK_DEBUG_FS bool "Block layer debugging information in debugfs" default y
These entries were consecutive at the time of their introduction but are no longer consecutive. Make these again consecutive. Additionally, modify the help text since it refers to blk-mq and since the legacy block layer has been removed. Cc: Damien Le Moal <damien.lemoal@wdc.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Ming Lei <ming.lei@redhat.com> Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> Cc: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)