| Message ID | 20210608162623.3010726-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | fpga: reorganize to subdirs | expand |
On Tue, Jun 08, 2021 at 09:26:23AM -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > It is not necessary to have an altera- prefix on a file > when the file is in an altera/ subdir. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/fpga/altera/Makefile | 12 ++++++------ > drivers/fpga/altera/{altera-cvp.c => cvp.c} | 0 > .../altera/{altera-fpga2sdram.c => fpga2sdram.c} | 0 > .../{altera-freeze-bridge.c => freeze-bridge.c} | 0 > .../fpga/altera/{altera-hps2fpga.c => hps2fpga.c} | 0 > .../{altera-pr-ip-core-plat.c => pr-ip-core-plat.c} | 0 > .../altera/{altera-pr-ip-core.c => pr-ip-core.c} | 0 > drivers/fpga/altera/{altera-ps-spi.c => ps-spi.c} | 0 > 8 files changed, 6 insertions(+), 6 deletions(-) > rename drivers/fpga/altera/{altera-cvp.c => cvp.c} (100%) > rename drivers/fpga/altera/{altera-fpga2sdram.c => fpga2sdram.c} (100%) > rename drivers/fpga/altera/{altera-freeze-bridge.c => freeze-bridge.c} (100%) > rename drivers/fpga/altera/{altera-hps2fpga.c => hps2fpga.c} (100%) > rename drivers/fpga/altera/{altera-pr-ip-core-plat.c => pr-ip-core-plat.c} (100%) > rename drivers/fpga/altera/{altera-pr-ip-core.c => pr-ip-core.c} (100%) > rename drivers/fpga/altera/{altera-ps-spi.c => ps-spi.c} (100%) > > diff --git a/drivers/fpga/altera/Makefile b/drivers/fpga/altera/Makefile > index 4d725c72fcbef..c2d626cd1f540 100644 > --- a/drivers/fpga/altera/Makefile > +++ b/drivers/fpga/altera/Makefile > @@ -1,12 +1,12 @@ > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += altera-freeze-bridge.o > -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o > -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o > -obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += altera-cvp.o > -obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += altera-ps-spi.o > +obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += freeze-bridge.o > +obj-$(CONFIG_ALTERA_PR_IP_CORE) += pr-ip-core.o > +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += pr-ip-core-plat.o > +obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += cvp.o > +obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += ps-spi.o > obj-$(CONFIG_FPGA_MGR_SOCFPGA) += socfpga.o > obj-$(CONFIG_FPGA_MGR_SOCFPGA_A10) += socfpga-a10.o > obj-$(CONFIG_FPGA_MGR_STRATIX10_SOC) += stratix10-soc.o > obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o > -obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += altera-hps2fpga.o altera-fpga2sdram.o > +obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += hps2fpga.o fpga2sdram.o Same issue here, you are renaming the resulting module for no good reason. Please never do that unless you mean to, AND, you document why you are doing so in the changelog text. thanks, greg k-h
diff --git a/drivers/fpga/altera/Makefile b/drivers/fpga/altera/Makefile index 4d725c72fcbef..c2d626cd1f540 100644 --- a/drivers/fpga/altera/Makefile +++ b/drivers/fpga/altera/Makefile @@ -1,12 +1,12 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += altera-freeze-bridge.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o -obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += altera-cvp.o -obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += altera-ps-spi.o +obj-$(CONFIG_ALTERA_FREEZE_BRIDGE) += freeze-bridge.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_ALTERA_CVP) += cvp.o +obj-$(CONFIG_FPGA_MGR_ALTERA_PS_SPI) += ps-spi.o obj-$(CONFIG_FPGA_MGR_SOCFPGA) += socfpga.o obj-$(CONFIG_FPGA_MGR_SOCFPGA_A10) += socfpga-a10.o obj-$(CONFIG_FPGA_MGR_STRATIX10_SOC) += stratix10-soc.o obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o -obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += altera-hps2fpga.o altera-fpga2sdram.o +obj-$(CONFIG_SOCFPGA_FPGA_BRIDGE) += hps2fpga.o fpga2sdram.o diff --git a/drivers/fpga/altera/altera-cvp.c b/drivers/fpga/altera/cvp.c similarity index 100% rename from drivers/fpga/altera/altera-cvp.c rename to drivers/fpga/altera/cvp.c diff --git a/drivers/fpga/altera/altera-fpga2sdram.c b/drivers/fpga/altera/fpga2sdram.c similarity index 100% rename from drivers/fpga/altera/altera-fpga2sdram.c rename to drivers/fpga/altera/fpga2sdram.c diff --git a/drivers/fpga/altera/altera-freeze-bridge.c b/drivers/fpga/altera/freeze-bridge.c similarity index 100% rename from drivers/fpga/altera/altera-freeze-bridge.c rename to drivers/fpga/altera/freeze-bridge.c diff --git a/drivers/fpga/altera/altera-hps2fpga.c b/drivers/fpga/altera/hps2fpga.c similarity index 100% rename from drivers/fpga/altera/altera-hps2fpga.c rename to drivers/fpga/altera/hps2fpga.c diff --git a/drivers/fpga/altera/altera-pr-ip-core-plat.c b/drivers/fpga/altera/pr-ip-core-plat.c similarity index 100% rename from drivers/fpga/altera/altera-pr-ip-core-plat.c rename to drivers/fpga/altera/pr-ip-core-plat.c diff --git a/drivers/fpga/altera/altera-pr-ip-core.c b/drivers/fpga/altera/pr-ip-core.c similarity index 100% rename from drivers/fpga/altera/altera-pr-ip-core.c rename to drivers/fpga/altera/pr-ip-core.c diff --git a/drivers/fpga/altera/altera-ps-spi.c b/drivers/fpga/altera/ps-spi.c similarity index 100% rename from drivers/fpga/altera/altera-ps-spi.c rename to drivers/fpga/altera/ps-spi.c