diff mbox series

nl80211: fix a mistake in grammar

Message ID 20210609081556.19641-1-13145886936@163.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series nl80211: fix a mistake in grammar | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

gushengxian June 9, 2021, 8:15 a.m. UTC
From: gushengxian <gushengxian@yulong.com>

Fix a mistake in grammar.

Signed-off-by: gushengxian <gushengxian@yulong.com>
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Berg June 9, 2021, 8:55 a.m. UTC | #1
On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
> 
> -	/* don't allow or configure an mcast address */
> +	/* don't allow or configure a mcast address */

Arguable? I'd say "an M-cast" address, and I guess that's why it's
written that way. Not sure how else you'd say it, unless you always
expand it to "multicast" when reading.

johannes
Randy Dunlap June 9, 2021, 3:01 p.m. UTC | #2
On 6/9/21 1:55 AM, Johannes Berg wrote:
> On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
>>
>> -	/* don't allow or configure an mcast address */
>> +	/* don't allow or configure a mcast address */
> 
> Arguable? I'd say "an M-cast" address, and I guess that's why it's
> written that way. Not sure how else you'd say it, unless you always
> expand it to "multicast" when reading.

Agreed, it's ok as is.
diff mbox series

Patch

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index fc9286afe3c9..68dff0ca3190 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -8128,7 +8128,7 @@  int nl80211_parse_random_mac(struct nlattr **attrs,
 	memcpy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC]), ETH_ALEN);
 	memcpy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK]), ETH_ALEN);
 
-	/* don't allow or configure an mcast address */
+	/* don't allow or configure a mcast address */
 	if (!is_multicast_ether_addr(mac_addr_mask) ||
 	    is_multicast_ether_addr(mac_addr))
 		return -EINVAL;