| Message ID | 20210609170512.297623-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 345502af4e42cef57782118520c3c326b55f1071 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] net: stmmac: Fix missing { } around two statements in an if statement | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 13 of 13 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 9 Jun 2021 18:05:12 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are missing { } around a block of code on an if statement. Fix this > by adding them in. > > Addresses-Coverity: ("Nesting level does not match indentation") > Fixes: 46682cb86a37 ("net: stmmac: enable Intel mGbE 2.5Gbps link speed") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] net: stmmac: Fix missing { } around two statements in an if statement https://git.kernel.org/netdev/net-next/c/345502af4e42 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1c881ec8cd04..1f817b1b890c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -932,9 +932,10 @@ static void stmmac_validate(struct phylink_config *config, phylink_set(mask, 1000baseT_Full); phylink_set(mask, 1000baseX_Full); } else if (priv->plat->has_gmac4) { - if (!max_speed || max_speed >= 2500) + if (!max_speed || max_speed >= 2500) { phylink_set(mac_supported, 2500baseT_Full); phylink_set(mac_supported, 2500baseX_Full); + } } else if (priv->plat->has_xgmac) { if (!max_speed || (max_speed >= 2500)) { phylink_set(mac_supported, 2500baseT_Full);