| Message ID | 1623317883-54209-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [-next] selinux: Fix kernel-doc | expand |
On Thu, Jun 10, 2021 at 5:38 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > > Fix function name in ss/services.c kernel-doc comment > to remove a warning found by running make W=1 LLVM=1. > > security/selinux/ss/services.c:2437: warning: expecting prototype for > security_pkey_sid(). Prototype was for security_ib_pkey_sid() instead. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > security/selinux/ss/services.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c > index 3658488..bb043bf 100644 > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -2423,7 +2423,7 @@ int security_port_sid(struct selinux_state *state, > } > > /** > - * security_pkey_sid - Obtain the SID for a pkey. > + * security_ib_pkey_sid - Obtain the SID for a pkey. > * @subnet_prefix: Subnet Prefix > * @pkey_num: pkey number > * @out_sid: security identifier This kdoc function header block is also missing the selinux_state description. Would you mind adding something like the following and resubmitting your patch? * @state: SELinux state ... I suspect there are a number of function header comments with similar problems in the SELinux code.
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index 3658488..bb043bf 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -2423,7 +2423,7 @@ int security_port_sid(struct selinux_state *state, } /** - * security_pkey_sid - Obtain the SID for a pkey. + * security_ib_pkey_sid - Obtain the SID for a pkey. * @subnet_prefix: Subnet Prefix * @pkey_num: pkey number * @out_sid: security identifier
Fix function name in ss/services.c kernel-doc comment to remove a warning found by running make W=1 LLVM=1. security/selinux/ss/services.c:2437: warning: expecting prototype for security_pkey_sid(). Prototype was for security_ib_pkey_sid() instead. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- security/selinux/ss/services.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)